[Debian-med-packaging] Bug#921122: pbbam: failing autopkgtests depend on generated files in source tree

[Steve Langasek]

Package: pbbam
Version: 0.19.0+dfsg-1
Severity: serious
Tags: patch
Justification: autopkgtest failures block migration
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch

Dear Afif,

Since the upload of 0.18.0+dfsg-1, pbbam's autopkgtests have been
consistently failing because the following code in debian/rules finds no
files in the tree:

  synthetic_movie_all_path=`find $$PWD -name synthetic_movie_all.subreadset.xml` ; \

The file synthetic_movie_all.subreadset.xml is generated at build time, but
depended on by the autopkgtests, which are run against an unbuilt source
tree.

The simplest way to fix this is to change the autopkgtest to use the
'build-needed' restriction, which causes the package to be built from source
during the autopkgtest.  There may be more efficient ways to just rebuild
only this data file used by the tests, but I'm not familiar with the meson
build system used by this package so I don't know the right way to do that.

Since regressed autopkgtests are now blockers for testing migration, I've
marked this bug as serious.

Please consider including the attached patch in Debian.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru pbbam-0.19.0+dfsg/debian/control pbbam-0.19.0+dfsg/debian/control
--- pbbam-0.19.0+dfsg/debian/control	2019-01-31 17:13:14.000000000 -0800
+++ pbbam-0.19.0+dfsg/debian/control	2019-02-01 12:15:46.000000000 -0800
@@ -1,6 +1,5 @@
 Source: pbbam
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian Med Packaging Team <debian-med-packaging at lists.alioth.debian.org>
+Maintainer: Debian Med Packaging Team <debian-med-packaging at lists.alioth.debian.org>
 Uploaders: Afif Elghraoui <afif at debian.org>
 Section: science
 Priority: optional
diff -Nru pbbam-0.19.0+dfsg/debian/tests/control pbbam-0.19.0+dfsg/debian/tests/control
--- pbbam-0.19.0+dfsg/debian/tests/control	2019-01-31 23:33:01.000000000 -0800
+++ pbbam-0.19.0+dfsg/debian/tests/control	2019-02-01 12:15:46.000000000 -0800
@@ -8,3 +8,4 @@
 Restrictions:
 	rw-build-tree,
 	allow-stderr,
+	build-needed,