[Debian-med-packaging] Bug#918566: Lost of code copies of MurmurHash3 (Was: Bug#918566: mash FTBFS on big endian: test failures)

[Andreas Tille]

Hi,

On Wed, Feb 06, 2019 at 01:20:48PM +0100, Andreas Tille wrote:
> On Mon, Feb 04, 2019 at 05:26:08PM +0100, Fabian Klötzl wrote:
> > So I improved the upstream libmurmurhash, adapted the package and filed an
> > ITP (#921353). I even managed to locally build mash against the new package.
> > So hereby I kindly ask you to fix the last lintian issue about NMU which I
> > don't fully understand and then maybe sponsor an upload.
> 
> I uploaded to new with my Automake patches and pinged ftpmaster via IRC.

I confirm I've tested mash with the now accepted libmurmurhash.
Unfortunately it does not pass its build time tests any more now that I
rebuild it for uploading.  I get lots of diffs in the expected and
calculated results.  It starts like this:

   dh_auto_test
        make -j4 test VERBOSE=1
make[1]: Entering directory '/build/mash-2.1+dfsg'
cd test ; ../mash sketch -o genomes.msh genome1.fna genome2.fna genome3.fna
cd test ; ../mash sketch -r -I reads reads1.fastq reads2.fastq -o reads.msh
Sketching genome1.fna...
Sketching genome2.fna...
Sketching genome3.fna...
Estimated genome size: 127897
Estimated coverage:    1.113
Writing to reads.msh...
Writing to genomes.msh...
./mash info -d test/genomes.msh > test/genomes.json
./mash dist test/genomes.msh test/reads.msh > test/genomes.dist
cd test ; ../mash screen genomes.msh reads1.fastq reads2.fastq > screen
Loading genomes.msh...
   1412 distinct hashes.
Streaming from 2 inputs...
./mash info -d test/reads.msh > test/reads.json
diff test/genomes.dist test/ref/genomes.dist
1,3c1,3
< genome1.fna   reads   0.124491        1.3814e-218     38/1000
< genome2.fna   reads   0.140258        1.1397e-151     27/1000
< genome3.fna   reads   0.124491        1.37891e-218    38/1000
---
> genome1.fna   reads   0.12101 4.48626e-214    41/1000
> genome2.fna   reads   0.12827 2.61074e-180    35/1000
> genome3.fna   reads   0.12101 4.45454e-214    41/1000
make[1]: *** [Makefile:97: testDist] Error 1
make[1]: *** Waiting for unfinished jobs....
diff test/genomes.json test/ref/genomes.json
7c7
<       "hashType" : "MurmurHash3_x86_32",
---
>       "hashType" : "MurmurHash3_x64_128",
18,1017c18,1017
...


I'm stoping here since this this is a suspicious one that might
(or might not) explain all the following diffs.  Any clue how to
solve this?

Kind regards

       Andreas.

-- 
http://fam-tille.de