[Debian-med-packaging] Bug#919778: Bug#918566: Lost of code copies of MurmurHash3 (Was: Bug#918566: mash FTBFS on big endian: test failures)

[Andreas Tille]

Hi Fabian,

On Thu, Feb 07, 2019 at 03:11:49PM +0100, Fabian Klötzl wrote:
> 
> > ./mash info -d test/reads.msh > test/reads.json
> > diff test/genomes.json test/ref/genomes.json
> > 7c7
> > <  "hashType" : "MurmurHash3_x86_32",
> > ---
> > >   "hashType" : "MurmurHash3_x64_128",
> 
> mash uses two different hash functions depending on the architecture:
> MurmurHash3_x86_32 for 32 bit and MurmurHash3_x64_128 for 64 bit
> architectures; These produce different hash values. The tests compare the
> results of one run with a precomputed result. However, the tests check
> against the 64bit reference. Thus they are bound to fail on 32bit. Hence my
> suggestion to turn the tests off for 32bit.

I've obviously missed that part of your mail.  It is fixed now and I'll
re-upload.

> > There are also build issues of libmurmurhash on some architectures[2]
> > 
> This is curious. One of the three hash functions is wrong, but at least
> consistently wrong. I'll look into that.

Meanwhile I've fixed the symbols file in Git.  Please git pull.

Kind regards

    Andreas.

-- 
http://fam-tille.de