[Debian-med-packaging] Bug#933471: ctsim: Please rebuild against wxWidgets GTK 3 package

[Andreas Tille]

Control: tags -1 help
Control: tags -1 upstream
Control: forwarded -1 Kevin M. Rosenberg <kevin at rosenberg.net>

Hi,

I think I have solved the issue below in Git despite I'm very curious
why I need to add a hack[1] to make sure all header files will be found
properly.

Unfortunately there is another build issue which I consider undependent
from the wxgtk migration (not sure, may be its related anyway or may be
its a gcc-9 issue?):

g++ -DHAVE_CONFIG_H -I. -I..  -I../include -I.. -I/usr/lib/x86_64-linux-gnu/wx/include/gtk3-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -pthread  -Wdate-time -              D_FORTIFY_SOURCE=2 -DDATADIR="\"/usr/share\""  -g -O4 -DNDEBUG -fomit-frame-pointer -Wall -fopenmp -I/usr/include/ctn -c -o dialogs.o dialogs.cpp
views.cpp: In member function 'virtual void PhantomFileView::OnDraw(wxDC*)':
views.cpp:2435:21: error: variable 'SGPDriver driver' has initializer but incomplete type
   SGPDriver driver (dc, xsize, ysize);
                     ^~
views.cpp:2436:18: error: variable 'SGP sgp' has initializer but incomplete type
   SGP sgp (driver);
                  ^
views.cpp:2438:17: error: 'C_RED' was not declared in this scope
   sgp.setColor (C_RED);
                 ^~~~~
views.cpp:2438:17: note: suggested alternative: 'wxRED'
   sgp.setColor (C_RED);
                 ^~~~~
                 wxRED
views.cpp:2439:12: error: 'const class Phantom' has no member named 'show'
   rPhantom.show (sgp);
            ^~~~
views.cpp: In destructor 'virtual PlotFileView::~PlotFileView()':
views.cpp:3298:12: warning: possible problem detected in invocation of delete operator: [-Wdelete-incomplete]
     delete m_pEZPlot;
            ^~~~~~~~~
views.cpp:3298:12: warning: invalid use of incomplete type 'class EZPlot'
In file included from ctsim.h:78,
                 from views.cpp:40:
dlgezplot.h:36:7: note: forward declaration of 'class EZPlot'
 class EZPlot;
       ^~~~~~
views.cpp:3298:12: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined
     delete m_pEZPlot;
            ^~~~~~~~~
...


I'm hereby forwarding the issue upstream.

Kind regards

       Andreas.


[1] https://salsa.debian.org/med-team/ctsim/blob/master/debian/patches/fix_includes.patch

On Tue, Jul 30, 2019 at 10:04:56AM -0400, swt at techie.net wrote:
> Package: ctsim
> Severity: normal
> 
> Hi,
> 
> Your package appears to be using the wxWidgets GTK 2 implementation.  In 
> Debian, we have had a GTK 3 implementation of wxWidgets for some time.  
> For the bullseye release, the wxWidgets package maintainers plan to 
> remove the GTK 2 version, so we kindly request that you switch your 
> package to use the GTK 3 version.  We have a transition tracker [1] 
> setup to track progress.
> 
> Switching to the GTK 3 version may be as simple as:
> 1) Update your Build-Depends
>    libwxgtk3.0-dev -> libwxgtk3.0-gtk3-dev
>    libwxgtk-media3.0-dev -> libwxgtk-media3.0-gtk3-dev
> 2) Rebuild
> 3) Test
> 
> If everything seems to be working fine, that's probably all you need to do.
> 
> There are a couple of known issues:
> 1) If your package uses wxGLCanvas, this doesn't currently work when running
> under Wayland.  As a workaround, you can force use of X.  See bug: [2]
> 2) If your package uses graphics contexts, it may encounter a problem with
> coordinate overflow.  See bug: [3]
> 
> If you have any questions, or need assistance with the conversion, please
> contact the wxWidgets team, team+wx at tracker.debian.org.
> 
> [1] https://release.debian.org/transitions/html/wxwidgets3.0-gtk3.html
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900678
> [3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906060
> 
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging

-- 
http://fam-tille.de