[Debian-med-packaging] Bug#933471: ctsim: Please rebuild against wxWidgets GTK 3 package

[Andreas Tille]

Hi Olly,

thanks for the hint.  Would you be able to propose a patch?

Kind regards

     Andreas.

On Thu, Aug 01, 2019 at 06:42:34AM +1200, Olly Betts wrote:
> On Wed, Jul 31, 2019 at 11:54:51AM +0200, Andreas Tille wrote:
> > I think I have solved the issue below in Git despite I'm very curious
> > why I need to add a hack[1] to make sure all header files will be found
> > properly.
> 
> You really should always run wx-config --cflags and put the result in
> CXXFLAGS (or whatever equivalent the build system has).
> 
> In some cases you might get away with not doing that, but not here -
> the libwxgtk3.0-dev and libwxgtk3.0-gtk3-dev packages are parallel
> installable so the appropriate header search path needs to be specified
> to the compiler.
> 
> > Unfortunately there is another build issue which I consider undependent
> > from the wxgtk migration (not sure, may be its related anyway or may be
> > its a gcc-9 issue?):
> 
> ctsim's configure.ac shows it probing directly for wx libraries:
> 
> | AC_CHECK_LIB(wx_gtk2u_core-3.0, main, [wxwin=true; wx_gtk=true; AC_DEFINE(HAVE_WXWINDOWS,1,[wxwindows library])], [], [-L/usr/lib64 -L/usr/lib ${GTK_LIBS} ${GLIB_LIBS} ])
> 
> That library name is specific to a GTK2 build, but really these checks
> should be done via wx-config (or one of the macros from wxwin.m4 which
> call wx-config behind the scenes).
> 
> I also notice direct probing for GTK2 in there:
> 
> |   AM_PATH_GTK_2_0(2.0.0,havegtk_am=yes,havegtk_am=no)
> 
> I'm not sure why that's done - a quick grep turned up no includes of gtk
> headers, and havegtk_am's value never seems to be used.  But it probably
> needs removing or updating to GTK3 if it's actually needed.
> 
> Cheers,
>     Olly
> 

-- 
http://fam-tille.de