[Debian-med-packaging] Bug#925728: lagan: ftbfs with GCC-9

[Matthias Klose]

Package: src:lagan
Version: 2.0-3
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-9

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-9/g++-9, but succeeds to build with gcc-8/g++-8. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc9-20190321/lagan_2.0-3_unstable_gcc9.log
The last lines of the build log are at the end of this report.

To build with GCC 9, either set CC=gcc-9 CXX=g++-9 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-9/porting_to.html

GCC 9 also passes the linker option --as-needed by default; typical
build issues are passing libraries before object files to the linker,
or underlinking of convenience libraries built from the same source.

[...]
   12 |   printf("  %d   %x\n", tbp->index, tbp->myelem);
      |                  ~^                 ~~~~~~~~~~~
      |                   |                    |
      |                   unsigned int         void *
      |                  %p
gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3  -o ../utils/cextract utils/cextract.c -Wl,-z,relro
gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3  -o ../utils/cstat utils/cstat.c -Wl,-z,relro
utils/cstat.c: In function 'cntlets':
utils/cstat.c:51:10: warning: implicit declaration of function 'isspace' [-Wimplicit-function-declaration]
   51 |     if (!isspace(currchar)) {
      |          ^~~~~~~
utils/cstat.c:52:18: warning: implicit declaration of function 'toupper' [-Wimplicit-function-declaration]
   52 |       currchar = toupper(currchar);
      |                  ^~~~~~~
filebuffer.c: In function 'FileRead':
filebuffer.c:123:34: warning: implicit declaration of function 'toupper' [-Wimplicit-function-declaration]
  123 |     temp[i] = (strchr (alphabet, toupper ((char) i)) != 0) ?
      |                                  ^~~~~~~
gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3  -o ../utils/contigorder utils/contigorder.c -Wl,-z,relro
utils/contigorder.c: In function 'getFileInfo':
utils/contigorder.c:15:57: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
   15 |     fprintf (stderr, "contigorder: Error opening file: %s\n");
      |                                                        ~^
      |                                                         |
      |                                                         char *
utils/contigorder.c:26:18: warning: unknown conversion type character '&' in format [-Wformat=]
   26 |  fscanf (file, "%&d", &dummy);
      |                  ^
utils/contigorder.c:26:16: warning: too many arguments for format [-Wformat-extra-args]
   26 |  fscanf (file, "%&d", &dummy);
      |                ^~~~~
utils/contigorder.c: In function 'getScores':
utils/contigorder.c:52:57: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
   52 |     fprintf (stderr, "contigorder: Error opening file: %s\n");
      |                                                        ~^
      |                                                         |
      |                                                         char *
/usr/bin/ld: /tmp/ccUM9c0s.o: in function `connectToPrev':
./src/fchaos.c:532: undefined reference to `findPrev'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:14: ../chaos] Error 1
make[2]: *** Waiting for unfinished jobs....
skiplist.c: In function 'printSLE':
skiplist.c:12:19: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'void *' [-Wformat=]
   12 |   printf("  %d   %x\n", tbp->index, tbp->myelem);
      |                  ~^                 ~~~~~~~~~~~
      |                   |                    |
      |                   unsigned int         void *
      |                  %p
filebuffer.c: In function 'FileRead':
filebuffer.c:123:34: warning: implicit declaration of function 'toupper' [-Wimplicit-function-declaration]
  123 |     temp[i] = (strchr (alphabet, toupper ((char) i)) != 0) ?
      |                                  ^~~~~~~
skiplist.c: In function 'printSLE':
skiplist.c:12:19: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'void *' [-Wformat=]
   12 |   printf("  %d   %x\n", tbp->index, tbp->myelem);
      |                  ~^                 ~~~~~~~~~~~
      |                   |                    |
      |                   unsigned int         void *
      |                  %p
filebuffer.c: In function 'FileRead':
filebuffer.c:123:34: warning: implicit declaration of function 'toupper' [-Wimplicit-function-declaration]
  123 |     temp[i] = (strchr (alphabet, toupper ((char) i)) != 0) ?
      |                                  ^~~~~~~
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
dh_auto_build: cd src && make -j4 "INSTALL=install --strip-program=true" returned exit code 2
make[1]: *** [debian/rules:9: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2