[Debian-med-packaging] Bug#944572: simka: debian/rules does not trap for errors

[Santiago Vila]

Package: src:simka
Version: 1.5.1-1
Severity: serious
Tags: patch

Dear maintainer: The debian/rules file for this package has a "for"
which does not always trap errors if they happen. To see why this
is a problem, compare the following two Makefile snippets:

for command in false true; do $${command}; done
echo MARK

for command in true false; do $${command}; done
echo MARK

The first one will succeed, the second one will not, but
in fact none of them should really succeed.

The simple patch below should fix this.

Please see Debian Policy 4.6. "Error trapping in makefiles"
for a more complete explanation:

https://www.debian.org/doc/debian-policy/ch-source.html#error-trapping-in-makefiles

Thanks.

--- a/debian/rules
+++ b/debian/rules
@@ -15,7 +15,7 @@ override_dh_install:
 	rm -r debian/tmp/usr/example \
 		debian/tmp/usr/scripts
 	chrpath --delete debian/simka/usr/bin/*
-	for file in debian/simkamin/usr/share/simkamin/*.py; do mv "$$file" "$${file%%.py}"; done
+	set -e; for file in debian/simkamin/usr/share/simkamin/*.py; do mv "$$file" "$${file%%.py}"; done
 	mv debian/simkamin/usr/share/simkamin/simkaMin_utils debian/simkamin/usr/share/simkamin/simkaMin_utils.py
 	
 override_dh_fixperms: