[Debian-med-packaging] Bug#941581: gdpc: possibly unsuitable autopkgtest

[Graham Inggs]

Source: gdpc
Version: 2.2.5-9
User: debian-ci at lists.debian.org
Usertags: issue

Hi Maintainer

I noticed the following autopkgtest failure in Ubuntu:

autopkgtest [13:46:19]: test run-unit-test: [-----------------------
PASS
Killed
autopkgtest [13:46:30]: test run-unit-test: -----------------------]
autopkgtest [13:46:30]: test run-unit-test:  - - - - - - - - - - results 
- - - - - - - - - -
run-unit-test        FAIL non-zero exit status 137


It seemed that the autopkgtest was committing suicide if the process 
command line contained 'gdpc'.  I was able to work around this by making 
the kill command more specific, as in the the following patch:

--- a/debian/tests/run-unit-test
+++ b/debian/tests/run-unit-test
@@ -20,6 +20,6 @@
  xvfb-run --auto-servernum /usr/bin/gdpc m 2 d 10 erase usetypes xyz 2 
3 4 5 manytypes.test &

  sleep 10
-kill -9 `ps aux | grep -w "^${USER}.*${pkg}" | grep -v "0:0[0-9] grep " 
| grep -v "0:0[0-9] ps " | sed 
"s/^${USER}[[:space:]]\+\([0-9]\+\)[[:space:]]\+.*/\1/"`
+kill -9 `ps aux | grep -w "^${USER}.*/usr/bin/gdpc" | grep -v "0:0[0-9] 
grep " | grep -v "0:0[0-9] ps " | sed 
"s/^${USER}[[:space:]]\+\([0-9]\+\)[[:space:]]\+.*/\1/"`

  echo "PASS"


This solved the problem on amd64 and most other architectures.  However, 
on armhf, I saw the following:

autopkgtest [14:12:35]: test run-unit-test: [-----------------------
*** buffer overflow detected ***: /usr/bin/gdpc terminated
Aborted (core dumped)
PASS
autopkgtest [14:12:47]: test run-unit-test: -----------------------]
autopkgtest [14:12:49]: test run-unit-test:  - - - - - - - - - - results 
- - - - - - - - - -
run-unit-test        PASS


It seems gdpc crashed, but the autopkgtest still passed.

Regards
Graham