[Debian-med-packaging] Bug#939811: fastqtl FTCBFS: does not pass cross tools to make

[Helmut Grohne]

Source: fastqtl
Version: 2.184+dfsg-6
Tags: patch
User: debian-cross at lists.debian.org
Usertags: ftcbfs

fastqtl fails to cross build from source, because it does not pass cross
tools to make. The easiest way of doing so is using dh_auto_build. Even
then it continues to fail, because it invokes architecture-dependent
behaviour of make. As it selects dynamic linking, LIB_TABX becomes -lhts
and when this is used in a Makefile dependency, make fails finding itfor
it on the build architecture. For cross-portable Makefiles -l flags must
not show up in Makefile dependencies. Please consider applying the
attached patch.

Helmut
-------------- next part --------------
diff --minimal -Nru fastqtl-2.184+dfsg/debian/changelog fastqtl-2.184+dfsg/debian/changelog
--- fastqtl-2.184+dfsg/debian/changelog	2018-07-18 20:55:22.000000000 +0200
+++ fastqtl-2.184+dfsg/debian/changelog	2019-09-09 06:08:32.000000000 +0200
@@ -1,3 +1,12 @@
+fastqtl (2.184+dfsg-6.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Let dh_auto_build pass cross tools to make.
+    + cross.patch: Fix Makefile dependencies.
+
+ -- Helmut Grohne <helmut at subdivi.de>  Mon, 09 Sep 2019 06:08:32 +0200
+
 fastqtl (2.184+dfsg-6) unstable; urgency=medium
 
   * Team upload
diff --minimal -Nru fastqtl-2.184+dfsg/debian/patches/cross.patch fastqtl-2.184+dfsg/debian/patches/cross.patch
--- fastqtl-2.184+dfsg/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ fastqtl-2.184+dfsg/debian/patches/cross.patch	2019-09-09 06:08:28.000000000 +0200
@@ -0,0 +1,11 @@
+--- fastqtl-2.184+dfsg.orig/Makefile
++++ fastqtl-2.184+dfsg/Makefile
+@@ -90,7 +90,7 @@
+ $(LIB_TABX):
+ 	cd $(PATH_TABX) && make && cd ../..
+ 
+-$(FILE_BIN): $(FILE_O) $(LIB_TABX)
++$(FILE_BIN): $(FILE_O) $(if $(DYNAMIC_LINK),,$(LIB_TABX))
+ 	$(CXX) $(LDFLAG) $^ $(LIB) -o $@
+ 
+ obj/%.o: %.cpp $(FILE_H)
diff --minimal -Nru fastqtl-2.184+dfsg/debian/patches/series fastqtl-2.184+dfsg/debian/patches/series
--- fastqtl-2.184+dfsg/debian/patches/series	2018-07-18 20:55:22.000000000 +0200
+++ fastqtl-2.184+dfsg/debian/patches/series	2019-09-09 06:08:03.000000000 +0200
@@ -1,3 +1,4 @@
 01_Makefile_dynamic_hardenings.patch
 02_Replace_libtabix_by_libhts.patch
 03_Reproducible_builds.patch
+cross.patch
diff --minimal -Nru fastqtl-2.184+dfsg/debian/rules fastqtl-2.184+dfsg/debian/rules
--- fastqtl-2.184+dfsg/debian/rules	2018-07-18 20:55:22.000000000 +0200
+++ fastqtl-2.184+dfsg/debian/rules	2019-09-09 06:04:47.000000000 +0200
@@ -11,7 +11,7 @@
 override_dh_auto_build:
 	mkdir -p $(CURDIR)/obj/
 	mkdir -p $(CURDIR)/bin/
-	$(MAKE) CXXFLAGS='$(CXXFLAGS)'
+	dh_auto_build -- CXXFLAGS='$(CXXFLAGS)'
 	cd $(CURDIR)/example/ && \
 		tar Jcvf examples.tar.xz * --sort=name --mode=go=rX,u+rw,a-s --owner=root --group=root --numeric-owner