[Debian-med-packaging] Comments regarding gmap_2020-04-08+ds-1_amd64.changes

[Scott Kitterman]

I am reluctantly going to accept this since this is a step forward from
non-free, but there is work to be done.

Don't override lintian for binary-without-manpage.  Overrides are for cases
where lintian is wrong, not where you don't care to do the work.  It hides
issues in a way that is contrary to Debian values.  Maybe someone will
contribute man pages if they discover the need.  Even a 'nothing here, look in
X location for documentation' man page has value.

The license grant for Apache2.0 needs to be in debian/copyright:

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.

The files src/getopt.* are code copies from the GNU C Library.  Policy
strongly prefers (but does not require) us to avoid embedded copies.  Please
discuss with upstream to see if this can be removed in a future release.
Additionally, the main package is Apache2.0 and these files are LGPL-2.1+.
These licenses are incompatible, fortunately the + is there because LGPL-3 is
compatible with Apache 2.0.  It would be good to add a comment to that stanza
of debian/copyright to indicate that while the files are LGPL-2+, Debian is
distributing them under the terms of LGPL-3.

There is binary data of unclear provenence in tests/.  Please document its
source like r-pkg-team does.  See [1] for an example.  That or remove the
files.

[1] https://salsa.debian.org/r-pkg-team/r-bioc-tcgabiolinks/-/blob/master/debian/README.source

There's no need to include AUTHORS in debian/doc.  To the extent that's needed
it is in debian/copyright already.

Scott K