[Debian-med-packaging] Bug#957487: libzstd: ftbfs with GCC-10

[Matthias Klose]

Package: src:libzstd
Version: 1.4.4+dfsg-3
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/libzstd_1.4.4+dfsg-3_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
==> compiling dynamic library 1.4.4
cc -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I./common -DXXH_NAMESPACE=ZSTD_ -I./legacy -DZSTD_LEGACY_SUPPORT=5 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security   -DZSTD_LEGACY_MULTITHREADED_API common/debug.c common/entropy_common.c common/error_private.c common/fse_decompress.c common/pool.c common/threading.c common/xxhash.c common/zstd_common.c compress/fse_compress.c compress/hist.c compress/huf_compress.c compress/zstd_compress.c compress/zstd_compress_literals.c compress/zstd_compress_sequences.c compress/zstd_double_fast.c compress/zstd_fast.c compress/zstd_lazy.c compress/zstd_ldm.c compress/zstd_opt.c compress/zstdmt_compress.c decompress/huf_decompress.c decompress/zstd_ddict.c decompress/zstd_decompress.c decompress/zstd_decompress_block.c deprecated/zbuff_common.c deprecated/zbuff_compress.c deprecated/zbuff_decompress.c dictBuilder/cover.c dictBuilder/divsufsort.c dictBuilder/fastcover.c dictBuilder/zdict.c legacy/zstd_v05.c legacy/zstd_v06.c legacy/zstd_v07.c -Wl,-z,relro -Wl,-z,now -shared -fPIC -fvisibility=hidden -Wl,-soname=libzstd.so.1 -o libzstd.so.1.4.4
==> compiling static library
ar rcs libzstd.a common/debug.o common/entropy_common.o common/error_private.o common/fse_decompress.o common/pool.o common/threading.o common/xxhash.o common/zstd_common.o compress/fse_compress.o compress/hist.o compress/huf_compress.o compress/zstd_compress.o compress/zstd_compress_literals.o compress/zstd_compress_sequences.o compress/zstd_double_fast.o compress/zstd_fast.o compress/zstd_lazy.o compress/zstd_ldm.o compress/zstd_opt.o compress/zstdmt_compress.o decompress/huf_decompress.o decompress/zstd_ddict.o decompress/zstd_decompress.o decompress/zstd_decompress_block.o deprecated/zbuff_common.o deprecated/zbuff_compress.o deprecated/zbuff_decompress.o dictBuilder/cover.o dictBuilder/divsufsort.o dictBuilder/fastcover.o dictBuilder/zdict.o legacy/zstd_v05.o legacy/zstd_v06.o legacy/zstd_v07.o
make[3]: Leaving directory '/<<PKGBUILDDIR>>/programs'
cp programs/zstd .
creating versioned links
ln -sf libzstd.so.1.4.4 libzstd.so.1
ln -sf libzstd.so.1.4.4 libzstd.so
make[3]: Leaving directory '/<<PKGBUILDDIR>>/lib'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build --sourcedirectory=contrib/pzstd/ -- pzstd
	cd contrib/pzstd && make -j4 "INSTALL=install --strip-program=true" pzstd
make[2]: Entering directory '/<<PKGBUILDDIR>>/contrib/pzstd'
g++ -MMD -MP -MF main.Td  -Wdate-time -D_FORTIFY_SOURCE=2 -I../../lib -I../../lib/common -I../../programs -I. -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -std=c++11 -c main.cpp  -o main.o
g++ -MMD -MP -MF Options.Td  -Wdate-time -D_FORTIFY_SOURCE=2 -I../../lib -I../../lib/common -I../../programs -I. -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -std=c++11 -c Options.cpp  -o Options.o
g++ -MMD -MP -MF Pzstd.Td  -Wdate-time -D_FORTIFY_SOURCE=2 -I../../lib -I../../lib/common -I../../programs -I. -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -std=c++11 -c Pzstd.cpp  -o Pzstd.o
g++ -MMD -MP -MF SkippableFrame.Td  -Wdate-time -D_FORTIFY_SOURCE=2 -I../../lib -I../../lib/common -I../../programs -I. -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -std=c++11 -c SkippableFrame.cpp  -o SkippableFrame.o
mv -f SkippableFrame.Td SkippableFrame.d
mv -f main.Td main.d
mv -f Options.Td Options.d
mv -f Pzstd.Td Pzstd.d
g++ main.o ../../programs/util.o Options.o Pzstd.o SkippableFrame.o ../../lib/libzstd.a           -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now   -pthread -o pzstd
make[2]: Leaving directory '/<<PKGBUILDDIR>>/contrib/pzstd'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
	make -j4 test
make[1]: Entering directory '/<<PKGBUILDDIR>>'
MOREFLAGS="-g -DDEBUGLEVEL=1 -Werror" make -j -C programs allVariants
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: warning: -j0 forced in submake: resetting jobserver mode.
cc -Wdate-time -D_FORTIFY_SOURCE=2 -I../lib -I../lib/common -I../lib/compress -I../lib/dictBuilder -DXXH_NAMESPACE=ZSTD_ -I../lib/legacy -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings -Wredundant-decls -Wmissing-prototypes -Wc++-compat -g -DDEBUGLEVEL=1 -Werror -Wl,-z,relro -Wl,-z,now -DZSTD_NOBENCH -DZSTD_NODICT -DZSTD_NODECOMPRESS ../lib/common/fse_decompress.c ../lib/common/entropy_common.c ../lib/common/pool.c ../lib/common/error_private.c ../lib/common/xxhash.c ../lib/common/debug.c ../lib/common/threading.c ../lib/common/zstd_common.c ../lib/compress/zstd_lazy.c ../lib/compress/zstd_double_fast.c ../lib/compress/zstd_fast.c ../lib/compress/zstd_ldm.c ../lib/compress/hist.c ../lib/compress/huf_compress.c ../lib/compress/fse_compress.c ../lib/compress/zstd_compress_literals.c ../lib/compress/zstd_compress_sequences.c ../lib/compress/zstd_compress.c ../lib/compress/zstdmt_compress.c ../lib/compress/zstd_opt.c zstdcli.c util.c timefn.c fileio.c -o zstd-compress
cc -Wdate-time -D_FORTIFY_SOURCE=2 -I../lib -I../lib/common -I../lib/compress -I../lib/dictBuilder -DXXH_NAMESPACE=ZSTD_ -I../lib/legacy -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings -Wredundant-decls -Wmissing-prototypes -Wc++-compat -g -DDEBUGLEVEL=1 -Werror -Wl,-z,relro -Wl,-z,now -DZSTD_NOBENCH -DZSTD_NODICT -DZSTD_NOCOMPRESS ../lib/common/fse_decompress.c ../lib/common/entropy_common.c ../lib/common/pool.c ../lib/common/error_private.c ../lib/common/xxhash.c ../lib/common/debug.c ../lib/common/threading.c ../lib/common/zstd_common.c ../lib/decompress/zstd_decompress.c ../lib/decompress/huf_decompress.c ../lib/decompress/zstd_decompress_block.c ../lib/decompress/zstd_ddict.c zstdcli.c util.c timefn.c fileio.c -o zstd-decompress
cc -Wdate-time -D_FORTIFY_SOURCE=2 -I../lib -I../lib/common -I../lib/compress -I../lib/dictBuilder -DXXH_NAMESPACE=ZSTD_ -I../lib/legacy -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Os -s -Wl,-z,relro -Wl,-z,now -DZSTD_NOBENCH -DZSTD_NODICT ../lib/decompress/zstd_decompress.c ../lib/decompress/huf_decompress.c ../lib/decompress/zstd_decompress_block.c ../lib/decompress/zstd_ddict.c ../lib/common/fse_decompress.c ../lib/common/entropy_common.c ../lib/common/pool.c ../lib/common/error_private.c ../lib/common/xxhash.c ../lib/common/debug.c ../lib/common/threading.c ../lib/common/zstd_common.c ../lib/compress/zstd_lazy.c ../lib/compress/zstd_double_fast.c ../lib/compress/zstd_fast.c ../lib/compress/zstd_ldm.c ../lib/compress/hist.c ../lib/compress/huf_compress.c ../lib/compress/fse_compress.c ../lib/compress/zstd_compress_literals.c ../lib/compress/zstd_compress_sequences.c ../lib/compress/zstd_compress.c ../lib/compress/zstdmt_compress.c ../lib/compress/zstd_opt.c zstdcli.c util.c timefn.c fileio.c -o zstd-small
cc -Wdate-time -D_FORTIFY_SOURCE=2 -I../lib -I../lib/common -I../lib/compress -I../lib/dictBuilder -DXXH_NAMESPACE=ZSTD_ -I../lib/legacy -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings -Wredundant-decls -Wmissing-prototypes -Wc++-compat -g -DDEBUGLEVEL=1 -Werror -Wl,-z,relro -Wl,-z,now ../lib/decompress/zstd_decompress.c ../lib/decompress/huf_decompress.c ../lib/decompress/zstd_decompress_block.c ../lib/decompress/zstd_ddict.c ../lib/common/fse_decompress.c ../lib/common/entropy_common.c ../lib/common/pool.c ../lib/common/error_private.c ../lib/common/xxhash.c ../lib/common/debug.c ../lib/common/threading.c ../lib/common/zstd_common.c ../lib/compress/zstd_lazy.c ../lib/compress/zstd_double_fast.c ../lib/compress/zstd_fast.c ../lib/compress/zstd_ldm.c ../lib/compress/hist.c ../lib/compress/huf_compress.c ../lib/compress/fse_compress.c ../lib/compress/zstd_compress_literals.c ../lib/compress/zstd_compress_sequences.c ../lib/compress/zstd_compress.c ../lib/compress/zstdmt_compress.c ../lib/compress/zstd_opt.c ../lib/dictBuilder/divsufsort.c ../lib/dictBuilder/zdict.c ../lib/dictBuilder/cover.c ../lib/dictBuilder/fastcover.c zstdcli.o util.o fileio.c benchfn.o benchzstd.o timefn.o datagen.o dibio.o -o zstd-nolegacy -Wl,-z,relro -Wl,-z,now
../lib/compress/zstd_compress_literals.c: In function ‘ZSTD_compressLiterals’:
../lib/compress/zstd_compress_literals.c:106:28: error: dereferencing type-punned pointer might break strict-aliasing rules [-Werror=strict-aliasing]
  106 |                 (HUF_CElt*)nextHuf->CTable, &repeat, preferRepeat, bmi2) :
      |                            ^~~~~~~
../lib/compress/zstd_compress_literals.c:110:28: error: dereferencing type-punned pointer might break strict-aliasing rules [-Werror=strict-aliasing]
  110 |                 (HUF_CElt*)nextHuf->CTable, &repeat, preferRepeat, bmi2);
      |                            ^~~~~~~
cc1: all warnings being treated as errors
../lib/compress/zstd_compress.c: In function ‘ZSTD_loadZstdDictionary’:
../lib/compress/zstd_compress.c:2807:64: error: dereferencing type-punned pointer might break strict-aliasing rules [-Werror=strict-aliasing]
 2807 |         size_t const hufHeaderSize = HUF_readCTable((HUF_CElt*)bs->entropy.huf.CTable, &maxSymbolValue, dictPtr, dictEnd-dictPtr);
      |                                                                ^~
cc1: all warnings being treated as errors
../lib/compress/zstd_compress_literals.c: In function ‘ZSTD_compressLiterals’:
../lib/compress/zstd_compress_literals.c:106:28: error: dereferencing type-punned pointer might break strict-aliasing rules [-Werror=strict-aliasing]
  106 |                 (HUF_CElt*)nextHuf->CTable, &repeat, preferRepeat, bmi2) :
      |                            ^~~~~~~
../lib/compress/zstd_compress_literals.c:110:28: error: dereferencing type-punned pointer might break strict-aliasing rules [-Werror=strict-aliasing]
  110 |                 (HUF_CElt*)nextHuf->CTable, &repeat, preferRepeat, bmi2);
      |                            ^~~~~~~
cc1: all warnings being treated as errors
../lib/compress/zstd_compress.c: In function ‘ZSTD_loadZstdDictionary’:
../lib/compress/zstd_compress.c:2807:64: error: dereferencing type-punned pointer might break strict-aliasing rules [-Werror=strict-aliasing]
 2807 |         size_t const hufHeaderSize = HUF_readCTable((HUF_CElt*)bs->entropy.huf.CTable, &maxSymbolValue, dictPtr, dictEnd-dictPtr);
      |                                                                ^~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:232: zstd-compress] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:193: zstd-nolegacy] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/programs'
make[1]: *** [Makefile:70: test] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: error: make -j4 test returned exit code 2
make: *** [debian/rules:16: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2