[Debian-med-packaging] Bug#957054: bowtie2: ftbfs with GCC-10

[Jun Aruga]

> The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/bowtie2_2.3.5.1-6_unstable_gcc10.log

Here is the error causing the build failures.

processor_support.h:52:22: error: extended character “ is not valid
in an identifier
   52 |         std::cerr << “ERROR: please define __cpuid() for
this build.\n†;
      |                      ^
processor_support.h:52:72: error: extended character † is not valid
in an identifier
   52 |         std::cerr << “ERROR: please define __cpuid() for
this build.\n†;

Here is the solution.

https://github.com/junaruga/fedora-bowtie2/blob/master/bowtie2.spec#L58-L61
# Invalid double quote characters are used in the code.
# https://github.com/BenLangmead/bowtie2/issues/278
sed -i 's/“/"/g' processor_support.h
sed -i 's/”/"/g' processor_support.h

I faced the error when preparing bowtie2 RPM on Fedora project's gcc
10 environment.