[Debian-med-packaging] Issues with parallel build (Was: Linker issues for libssw on armel, mips64el and mipsel)

[Andreas Tille]

Hi,

On Wed, Aug 12, 2020 at 09:01:07AM +0100, Steve McIntyre wrote:
> On Wed, Aug 12, 2020 at 09:33:31AM +0200, Andreas Tille wrote:
> >...
> >c -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -I"/include" -I"/include/linux" -I/usr/lib/jvm/default-java/include/  -I/usr/lib/jvm/default-java/include/linux -fPIC -shared -rdynamic -o libsswjni.so sswjni.c ssw.c -Wl,-z,relro -Wl,-z,now
> >cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -o ssw-align main.c kseq.h -L. -lssw -lm -lz -Wl,-z,relro -Wl,-z,now
> >/usr/bin/ld: cannot find -lssw
> >...
> >
> >(same on some non-released architectures).
> >
> >Any idea how to fix this?
> 
> Comparing the buildd logs for arm64 and armel, there are obvious
> differences - on armel the build doesn't even attempt to make the
> library libssw.a. Check the Makefiles etc. to see if it has hard-coded
> architecture support?

I failed to find some architecture specific issues (as long as

    ifneq ($(filter nojava,$(DEB_BUILD_PROFILES)),)

is not filtering for certain architectures implicitly.)

I think the issue is connected to parallel builds.  After comparing
build logs which look pretty similar between amd64 and armel I suspected
that there is some issue with parallel builds and forced --no-parallel
with the result that the build now even fails for amd64:

dh_auto_build --no-parallel --sourcedirectory src -- default java
        cd src && make -j1 "INSTALL=install --strip-program=true" default java
make[2]: Entering directory '/build/libssw-1.1/src'
g++ -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/libssw-1.1=. -fstack-protector-strong -Wformat -Werror=format-security -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -fPIC -shared -rdynamic -Wl,-soname,libssw.so.0 -o libssw.so.0 ssw.c ssw.h ssw_cpp.h ssw_cpp.cpp -Wl,-z,relro -Wl,-z,now
cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/libssw-1.1=. -fstack-protector-strong -Wformat -Werror=format-security -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -o ssw-align main.c kseq.h -L. -lssw -lm -lz -Wl,-z,relro -Wl,-z,now
/usr/bin/ld: cannot find -lssw


Michael Crusoe confirmed that  

  The package builds for me on armel as of
  https://salsa.debian.org/med-team/libssw/-/commit/a19c146931e078e0e56abc85684f5a3583165e63
  so perhaps the issue was introduced later?

I admit I re-applied former patches to create a static lib which was
kicked by the SIMDE patches but it seems I messed up the Makefile.
Any second pair of eyeballs finding what I might have made wrong
in Git[1] between the commit above and HEAD when re-adding the
static lib that was droped at some point in time?

Kind regards

       Andreas.


[1] https://salsa.debian.org/med-team/libssw

-- 
http://fam-tille.de