[Debian-med-packaging] Bug#976999: libfastahack: make .symbols file more resilient in handling of template symbols

[Steve Langasek]

Package: libfastahack
Version: 1.0.0+dfsg-6
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch

Hi Andreas,

The libfastahack package has been failing to build on ppc64el in Ubuntu due
to mismatched symbols file.  This is probably due to the fact that Ubuntu
builds all packages on ppc64el with -O3 by default, causing some symbols to
be inlined and optimized out of the symbol table.

Surprisingly, this build failure also includes some symbols that are *added*
on ppc64el relative to other architectures, which I can't say I've ever seen
before.  However, since these are also template symbols, they are irrelevant
to the ABI and can safely be marked as optional as well.

Please find attached a patch that allows the libfastahack build to succeed
on ppc64el in Ubuntu.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru libfastahack-1.0.0+dfsg/debian/libfastahack0.symbols libfastahack-1.0.0+dfsg/debian/libfastahack0.symbols
--- libfastahack-1.0.0+dfsg/debian/libfastahack0.symbols	2020-07-23 05:51:27.000000000 -0700
+++ libfastahack-1.0.0+dfsg/debian/libfastahack0.symbols	2020-12-09 12:51:45.000000000 -0800
@@ -32,11 +32,14 @@
  _ZN15FastaIndexEntryD1Ev at Base 0.0+git20160702.bbc645f
  _ZN15FastaIndexEntryD2Ev at Base 0.0+git20160702.bbc645f
  _ZNKSt5ctypeIcE8do_widenEc at Base 0.0+git20160702.bbc645f
+ (optional)_ZNSt12_Destroy_auxILb0EE9__destroyIPNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEvT_S9_ at Base 1.0.0+dfsg
+ (optional)_ZNSt4pairINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE15FastaIndexEntryED1Ev at Base 1.0.0+dfsg
+ (optional)_ZNSt4pairINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE15FastaIndexEntryED2Ev at Base 1.0.0+dfsg
  _ZNSt6vectorI15FastaIndexEntrySaIS0_EE17_M_realloc_insertIJRKS0_EEEvN9__gnu_cxx17__normal_iteratorIPS0_S2_EEDpOT_ at Base 0.0+git20160702.bbc645f
  _ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EE17_M_realloc_insertIJRKS5_EEEvN9__gnu_cxx17__normal_iteratorIPS5_S7_EEDpOT_ at Base 0.0+git20160702.bbc645f
  (optional)_ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EE17_M_realloc_insertIJS5_EEEvN9__gnu_cxx17__normal_iteratorIPS5_S7_EEDpOT_ at Base 0.0+git20160702.bbc645f
- _ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EEC1ERKS7_ at Base 1.0.0+dfsg
- _ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EEC2ERKS7_ at Base 1.0.0+dfsg
+ (optional)_ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EEC1ERKS7_ at Base 1.0.0+dfsg
+ (optional)_ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EEC2ERKS7_ at Base 1.0.0+dfsg
  _ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EED1Ev at Base 0.0+git20160702.bbc645f
  _ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EED2Ev at Base 0.0+git20160702.bbc645f
  _ZNSt8_Rb_treeINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESt4pairIKS5_15FastaIndexEntryESt10_Select1stIS9_ESt4lessIS5_ESaIS9_EE17_M_emplace_uniqueIJS6_IS5_S8_EEEES6_ISt17_Rb_tree_iteratorIS9_EbEDpOT_ at Base 0.0+git20160702.bbc645f
@@ -48,7 +51,7 @@
  _ZSt13__heap_selectIN9__gnu_cxx17__normal_iteratorIP15FastaIndexEntrySt6vectorIS2_SaIS2_EEEENS0_5__ops15_Iter_comp_iterIPFbS2_S2_EEEEvT_SD_SD_T0_ at Base 1.0.0+dfsg
  _ZSt16__insertion_sortIN9__gnu_cxx17__normal_iteratorIP15FastaIndexEntrySt6vectorIS2_SaIS2_EEEENS0_5__ops15_Iter_comp_iterIPFbS2_S2_EEEEvT_SD_T0_ at Base 0.0+git20160702.bbc645f
  _ZSt16__introsort_loopIN9__gnu_cxx17__normal_iteratorIP15FastaIndexEntrySt6vectorIS2_SaIS2_EEEElNS0_5__ops15_Iter_comp_iterIPFbS2_S2_EEEEvT_SD_T0_T1_ at Base 0.0+git20160702.bbc645f
- _ZSt22__move_median_to_firstIN9__gnu_cxx17__normal_iteratorIP15FastaIndexEntrySt6vectorIS2_SaIS2_EEEENS0_5__ops15_Iter_comp_iterIPFbS2_S2_EEEEvT_SD_SD_SD_T0_ at Base 1.0.0+dfsg
+ (optional)_ZSt22__move_median_to_firstIN9__gnu_cxx17__normal_iteratorIP15FastaIndexEntrySt6vectorIS2_SaIS2_EEEENS0_5__ops15_Iter_comp_iterIPFbS2_S2_EEEEvT_SD_SD_SD_T0_ at Base 1.0.0+dfsg
  _ZSt25__unguarded_linear_insertIN9__gnu_cxx17__normal_iteratorIP15FastaIndexEntrySt6vectorIS2_SaIS2_EEEENS0_5__ops14_Val_comp_iterIPFbS2_S2_EEEEvT_T0_ at Base 0.0+git20160702.bbc645f
  _ZlsRSoR10FastaIndex at Base 0.0+git20160702.bbc645f
  _ZlsRSoRK15FastaIndexEntry at Base 0.0+git20160702.bbc645f