[Debian-med-packaging] Bug#977120: insighttoolkit4: Clean target does not fully clean

[Wookey]

Source: insighttoolkit4
Version: 4.13.3withdata-dfsg1-3
Severity: normal
Tags: patch

After a build, a second attempt will fail because the source tree is dirty.
There is a set of cached python files left:
  Modules/ThirdParty/pygccxml/src/pygccxml/__pycache__/
  Modules/ThirdParty/pygccxml/src/pygccxml/declarations/__pycache__/
  Modules/ThirdParty/pygccxml/src/pygccxml/parser/__pycache__/
  Modules/ThirdParty/pygccxml/src/pygccxml/utils/__pycache__/

This could be fixed in various ways. I elected to use find in the
Modules/ThirdParty/pygccxml/src/pygccxml dir and execdir
override_dh_clean:
        # Modules/ThirdParty/pygccxml/src/pygccxml leaves build artifacts around
        find  Modules/ThirdParty/pygccxml/src -name __pycache__ -execdir rm -r '{}' +
        dh_clean

I also note that python3-pygccxml 1.9.1 is in debian (since 2018-08).
The version in the ThirdParty section above is 1.9.0.

I checked the diff and there are a few updates and improvements in
1.9.1 (e.g. error handling) but there is nothing special about the
version shipped with insighttoolkit so it does make sense to stop
using it, then this wouldn't be built and the issue of uncleaned files
from it would not arise.

patch attached 
-------------- next part --------------
commit 74d6f864b83a6fcede2aaf0c32ece07e51c00f3c
Author: Wookey <wookey at debian.org>
Date:   Fri Dec 11 02:41:05 2020 +0000

    Clean up uncleaned pycache files in Modules/ThirdParty/VNL/src/vxl

diff --git a/debian/rules b/debian/rules
index bda3bdc..e1b1263 100755
--- a/debian/rules
+++ b/debian/rules
@@ -147,6 +147,11 @@ ifneq (,$(filter $(pkg_examples), $(shell dh_listpackages)))
 	    -type f -print0 | xargs -0 chmod 644
 endif
 
+override_dh_clean:
+	# Modules/ThirdParty/pygccxml/src/pygccxml leaves build artifacts around
+	find  Modules/ThirdParty/pygccxml/src -name __pycache__ -execdir rm -r '{}' +
+	dh_clean
+
 control-file:
 	sed -e "s/@VER_MAJOR@/$(VER_MAJOR)/g" \
 	    -e "s/@SOVERSION@/$(SOVERSION)/g" \