[Debian-med-packaging] Bug#950969: stringtie FTCBFS: uses the build architecture compiler as linker

[Helmut Grohne]

Source: stringtie
Version: 2.1.1+ds-1
Tags: patch
User: debian-cross at lists.debian.org
Usertags: ftcbfs

stringtie fails to cross build from source, because it uses the build
architecture compiler as linker. This happens, because stringtie's
Makefile uses the non-standard variable LINKER and dh_auto_build doesn't
supply it. The attached patch passes it from dh_auto_build. An
alternative would be defaulting its value to $(CXX) as an upstream
improvement.

Still then, stringtie fails to cross build, because it uses help2man.
There are no good solutions to this problem. Options include:
 * Stop using help2man. Write a real manual page.
 * Move the manual page to an Architecture: all package.
 * Generate the manual page at upload time instead of build time.
 * Build twice, once for help2man and once for real.

None of these is particularly attractive. So let's just fix the LINKER
part here. Please close this bug when addressing that part.

Helmut
-------------- next part --------------
diff --minimal -Nru stringtie-2.1.1+ds/debian/changelog stringtie-2.1.1+ds/debian/changelog
--- stringtie-2.1.1+ds/debian/changelog	2020-02-07 16:33:31.000000000 +0100
+++ stringtie-2.1.1+ds/debian/changelog	2020-02-08 16:54:59.000000000 +0100
@@ -1,3 +1,10 @@
+stringtie (2.1.1+ds-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Improve cross building: Pass LINKER. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sat, 08 Feb 2020 16:54:59 +0100
+
 stringtie (2.1.1+ds-1) unstable; urgency=medium
 
   * Team upload.
diff --minimal -Nru stringtie-2.1.1+ds/debian/rules stringtie-2.1.1+ds/debian/rules
--- stringtie-2.1.1+ds/debian/rules	2020-02-07 16:24:51.000000000 +0100
+++ stringtie-2.1.1+ds/debian/rules	2020-02-08 16:54:58.000000000 +0100
@@ -10,6 +10,9 @@
 %:
 	dh $@
 
+override_dh_auto_build:
+	dh_auto_build -- 'LINKER=$$(CXX)'
+
 # Disabling tests, as they require network access. In future, a multiple
 # upstream tarball could be created to pull in the required test files.
 override_dh_auto_test: