[Debian-med-packaging] Bug#963246: vg FTBFS with Protobuf 3.12.3

[Adrian Bunk]

Control: severity -1 serious
Control: close -1 1.25.0+ds-1

On Sun, Jun 21, 2020 at 01:37:54PM +0200, László Böszörményi wrote:
> Source: vg
> Severity: normal
> Justification: fails to build from source (but built successfully in the past)
> Tags: upstream ftbfs
> 
> Hi,
> 
> Soon the Protobuf transition will start. Your package FTBFS with the Protobuf
> 3.12.3-1 version, currently in experimental. The relevant lines hopefully:
> . ./source_me.sh && g++ -I/usr/include/fastahack
> -I/build/vg-1.24.0+ds/include -I. -I/build/vg-1.24.0+ds/src
> -I/build/vg-1.24.0+ds/src/unittest
> -I/build/vg-1.24.0+ds/src/subcommand
> -I/build/vg-1.24.0+ds/include/dynamic -I/usr/include/cairo
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2
> -I/usr/include/libpng16 -I/usr/include/smithwaterman
> -I/usr/include/vcflib -I/usr/include/smithwaterman
> -I/usr/include/fastahack  -O3 -Werror=return-type -std=c++14 -ggdb -g
> -MMD -MP  -fopenmp -c -o obj/cactus_snarl_finder.o
> src/cactus_snarl_finder.cpp
> In file included from src/cactus_snarl_finder.hpp:10,
>                  from src/cactus_snarl_finder.cpp:13:
> src/snarls.hpp:607:12: error: cannot derive from 'final' base
> 'vg::Snarl' in derived type 'vg::SnarlManager::SnarlRecord'
>   607 |     struct SnarlRecord : public Snarl {
>       |            ^~~~~~~~~~~
> make: *** [Makefile:544: obj/cactus_snarl_finder.o] Error 1
> 
> Please contact your upstream or try to fix yourself.

This is fixed in 1.25.0:
https://buildd.debian.org/status/logs.php?pkg=vg&ver=1.25.0%2Bds-1%2Bb1
https://github.com/vgteam/vg/releases/tag/v1.25.0
  * Fix build of SNarlManager with latest Protobuf which prohibits 
    inheriting from messages

> Thanks,
> Laszlo/GCS

cu
Adrian