[Debian-med-packaging] Bug#965228: lighter FTBFS: narrowing conversions

[Helmut Grohne]

Source: lighter
Version: 1.1.2-2
Severity: important
Tags: patch ftbfs

lighter fails to build from source, because:

main.cpp:26:25: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]

What happens here is that nucToNum is assigned -1, but it is typed array
of char, which happens to be unsigned (on some architectures). It really
wants a small signed integer type here (representing numbers between -1
and 3). A very simple fix is using signed char (which isn't architecture
dependent). Please consider applying the attached patch.

Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ftbfs.patch
Type: text/x-diff
Size: 884 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20200717/285b880a/attachment.patch>