[Debian-med-packaging] biosig4c++ packaging in debian

[Alois Schlögl]

Am 7/20/20 um 11:52 AM schrieb Andreas Tille:
> Hi Alois,
>
> thanks a lot for your contribution.
>
> On Sat, Jul 18, 2020 at 09:48:17PM +0200, Alois Schlögl wrote:
>> please find attached a patch for debian packaging of biosig4c++.
>> swig and libxml2 are not used by biosig anymore, and the watch file need
>> to be addapted.
>>
>> There is a new release of biosig available, and I want to make you aware
>> of some major changes in the structure of the source code. Specifically,
>> biosig4c++ and biosig4octmat are now combined in a single source release.
>>
>> 1) I'd like to suggest changing the source package name
>> from "biosig4c++" to "biosig" (This would get rid of the "++" in the
>> package name, which can cause issues sometimes)
> I admit changing the source package name just for "esthetical reasons"
> is not the best idea.  The package would have to pass the Debian new
> queue and this usually takes time (and work).  So I would love to avoid
> this.


Hi Andreas,

thanks for your response. The main reason for renaming the source
package is the fact, than "Biosig for Octave and Matlab" (biosig4octmat)
and "Biosig for C/C++" (biosig4c++) are now combined in a single release
"Biosig".  In the past, these were release separately, and only
biosig4c++ was packaged in Debian. Now, I'd like to have also
"biosig4octmat" packaged. Therefore, I suggest to rename the source
package to debian.


<SNIP>


> I have applied your patch (thanks for this!) and upgraded to the new
> upstream package in Git[1].  My attemt to build the package ended in
>
> ...
> x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fwrapv -O2 -Wl,-z,relro -Wl,-z,now -g -O2 -fdebug-prefix-map=/build/biosig4c++-2.0.4=. -fstack-protector-strong -Wformat -Werror=format-security -I/build/biosig4c++-2.0.4 -Wdate-time -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.8/biosigmodule.o -L./.. -lbiosig -o build/lib.linux-x86_64-3.8/biosig.cpython-38-x86_64-linux-gnu.so
> /usr/lib/python3.8/distutils/dist.py:274: UserWarning: Unknown distribution option: 'long_description_content_type'
>   warnings.warn(msg)
> /usr/lib/python3.8/distutils/dist.py:274: UserWarning: Unknown distribution option: 'include_package_data'
>   warnings.warn(msg)
> /usr/lib/python3.8/distutils/dist.py:274: UserWarning: Unknown distribution option: 'install_requires'
>   warnings.warn(msg)
> make[3]: Leaving directory '/build/biosig4c++-2.0.4/biosig4c++/python'
> make[2]: Leaving directory '/build/biosig4c++-2.0.4'
> : # Assure additional interesting to us pieces are built
> make LIBEXT=so libbiosig.so mex4o biosig4python
> make[2]: Entering directory '/build/biosig4c++-2.0.4'
> make[2]: *** No rule to make target 'libbiosig.so'.  Stop.
> make[2]: Leaving directory '/build/biosig4c++-2.0.4'
> make[1]: *** [debian/rules:25: override_dh_auto_build] Error 2
>
>
> I wonder whether you might like to create a login on salsa.debian.org
> and commit any needed changes directly.  Given that you provided a
> helpful patch you are sufficently comfortable with Debian packaging.


I've registered at salsa.debian.org (username: schloegl). I've some
knowledge how packaging in debian is done, but I'm sure there are many
thinks I do not know about debian packaging. I've started with the steps
in 

https://wiki.debian.org/BuildingTutorial and had to setup fakeroot, etc.


Attached is a partial patch that addresses the errors above and gets us
further in packaging biosig-2.0.4, but handling the part of 
"biosig4octmat", is the next step that still needs to be addressed. 

The SONAMEVERSION is reverted back from 3 to 2, in order to avoid the
need to move from libbiosig2 to libbiosig3. The reason for pushing the
SONAMEVERSION to 3 was not a change in the API but visibility management
was introduced. Chances are this push of the SONAMEVERSION was not
necessary. Is there some check in Debian, whether a push in the
SONAMEVERSION is needed or not ?


Best,

   Alois



>  
>> Best regards,
>>    Alois
> Kind regards and thanks again for your contribution
>
> g    Andreas.
>
>
> [1] https://salsa.debian.org/med-team/biosig4c 
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-biosig-0001.diff
Type: text/x-patch
Size: 27754 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20200721/b3cfe598/attachment-0001.bin>