[Debian-med-packaging] orthanc-gdcm_1.0-1_amd64.changes REJECTED

[Andreas Tille]

On Thu, Jul 23, 2020 at 09:50:47AM +0200, Sébastien Jodogne wrote:
> Hi Andreas,
> 
> Thanks so much for your quick feedback!

You are more than welcome.  The package is uploaded to new now.

Thank you for your work, Andreas.
 
> Actually, all the missing files were properly installed, but this was
> done in a non-clean way. I have fixed the package, and all the
> dh_missing issues seem now to be solved [1].
> 
> Best,
> Sébastien-
> 
> 
> [1]
> https://salsa.debian.org/med-team/orthanc/-/commit/5f2a19cbd15de883380416f47458bf2523244804
> 
> 
> On 22/07/20 13:11, Andreas Tille wrote:
> > Hi Sébastien,
> > 
> > On Wed, Jul 22, 2020 at 11:50:12AM +0200, Sébastien Jodogne wrote:
> >> The long promised "complex upstream work" has been done in the context
> >> of the Orthanc 1.7.2 release, that was published two weeks ago.
> >>
> >> The Orthanc source distribution now allows to build a shared library
> >> called the "Orthanc framework" whose purpose is to share code between
> >> all the official Orthanc plugins.
> > 
> > Very nice.  I used the chance to run routine-update on the package to
> > modernise packaging a bit.  Debhelper compat level 13 is now forcing
> > dh_missing issues to be failures.  Since I'm not sure whether you
> > are aware that not all files are installed or whether this is really
> > a missing I'd like you to confirm this:
> > 
> > 
> > ...
> >    dh_missing
> > dh_missing: warning: usr/share/orthanc/plugins/libServeFolders.so exists in debian/tmp but is not installed to anywhere 
> > dh_missing: warning: usr/share/orthanc/plugins/libModalityWorklists.so exists in debian/tmp but is not installed to anywhere 
> > dh_missing: warning: usr/include/orthanc/OrthancCDatabasePlugin.h exists in debian/tmp but is not installed to anywhere 
> > dh_missing: warning: usr/include/orthanc/OrthancCPlugin.h exists in debian/tmp but is not installed to anywhere 
> > dh_missing: error: missing files, aborting
> >         The following debhelper tools have reported what they installed (with files per package)
> >          * dh_install: liborthancframework-dev (35), liborthancframework1 (2), orthanc (9), orthanc-dev (1), orthanc-doc (72)
> >          * dh_installdocs: liborthancframework-dev (0), liborthancframework1 (0), orthanc (0), orthanc-dev (0), orthanc-doc (0)
> >          * dh_installman: liborthancframework-dev (0), liborthancframework1 (0), orthanc (3), orthanc-dev (0), orthanc-doc (0)
> >         If the missing files are installed by another tool, please file a bug against it.
> >         When filing the report, if the tool is not part of debhelper itself, please reference the
> >         "Logging helpers and dh_missing" section from the "PROGRAMMING" guide for debhelper (10.6.3+).
> >           (in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.gz)
> >         Be sure to test with dpkg-buildpackage -A/-B as the results may vary when only a subset is built
> >         If the omission is intentional or no other helper can take care of this consider adding the
> >         paths to debian/not-installed.
> > make: *** [debian/rules:20: binary] Error 25
> > dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> > 
> > 
> > Kind regards
> > 
> >          Andreas.
> > 
> 

-- 
http://fam-tille.de