[Debian-med-packaging] Bug#954711: FTBFS with Boost 1.71

[Flavien BRIDAULT]

Hi Andreas,

Thanks for the patch and for the notification, I will file this in our
bug database.

This will be integrated in our next upcoming release.

Cheers,

Le 23/03/2020 à 08:08, Andreas Tille a écrit :
> Control: tags -1 upstream
> Control: forwarded -1 Flavien Bridault <fbridault at ircad.fr>
>
> Hi Flavien,
>
> you probably want to apply this patch upstream.  Please ping me
> once you prepared a new package for sponsored upload.
>
> Kind regards (and thanks to Giovanni for the patch)
>
>     Andreas.
>
> On Sun, Mar 22, 2020 at 03:03:05PM +0100, Giovanni Mascellani wrote:
>> Package: sight
>> Version: 19.0.0-5
>> Severity: wishlist
>> Tags: patch
>> User: team+boost at tracker.debian.org
>> Usertags: boost1.71
>>
>> Dear Maintainer,
>>
>> your package fails to build with boost1.71. You can find a build log
>> attached. If you want to attempt the build yourself, an updated version
>> of boost-defaults which brings in boost1.71 dependencies can be found
>> adding this line to your sources.list file:
>>
>>   deb https://people.debian.org/~gio/reprepro gio main
>>
>> This bug has severity whishlist for the moment, but it will raised to RC
>> as soon as version 1.71 of Boost is promoted to default.
>>
>> More specifically, your package fails building because CMake scripts use
>> capitalized Boost library names, while they should be lowercase.
>>
>> The attached patch should fix the bug.
>>
>> Thanks and all the best, Giovanni.
>> -- 
>> Giovanni Mascellani <g.mascellani at gmail.com>
>> Postdoc researcher - Université Libre de Bruxelles
>> From e2c25111e5f0df526cf46ba9039b49b50eba3fa5 Mon Sep 17 00:00:00 2001
>> From: Giovanni Mascellani <gio at debian.org>
>> Date: Sun, 22 Mar 2020 14:35:17 +0100
>> Subject: [PATCH] Fix FTBFS with Boost 1.71.
>>
>> ---
>>  debian/changelog                              |  7 ++++
>>  .../0007-Fix-FTBFS-with-Boost-1.71.patch      | 34 +++++++++++++++++++
>>  debian/patches/series                         |  1 +
>>  3 files changed, 42 insertions(+)
>>  create mode 100644 debian/patches/0007-Fix-FTBFS-with-Boost-1.71.patch
>>
>> diff --git a/debian/changelog b/debian/changelog
>> index 60579b5a..39ca5f34 100644
>> --- a/debian/changelog
>> +++ b/debian/changelog
>> @@ -1,3 +1,10 @@
>> +sight (19.0.0-5.1) UNRELEASED; urgency=medium
>> +
>> +  * Non-maintainer upload.
>> +  * Fix Boost library names in CMake scripts.
>> +
>> + -- Giovanni Mascellani <gio at debian.org>  Sun, 22 Mar 2020 14:35:31 +0100
>> +
>>  sight (19.0.0-5) unstable; urgency=medium
>>  
>>    * Team upload.
>> diff --git a/debian/patches/0007-Fix-FTBFS-with-Boost-1.71.patch b/debian/patches/0007-Fix-FTBFS-with-Boost-1.71.patch
>> new file mode 100644
>> index 00000000..c94167ff
>> --- /dev/null
>> +++ b/debian/patches/0007-Fix-FTBFS-with-Boost-1.71.patch
>> @@ -0,0 +1,34 @@
>> +From: Giovanni Mascellani <gio at debian.org>
>> +Date: Sun, 22 Mar 2020 14:34:26 +0100
>> +Subject: Fix FTBFS with Boost 1.71.
>> +
>> +Apparently CMake expects library names to be lowercase.
>> +---
>> + Bundles/ui/guiQml/CMakeLists.txt | 2 +-
>> + Bundles/ui/guiQt/CMakeLists.txt  | 2 +-
>> + 2 files changed, 2 insertions(+), 2 deletions(-)
>> +
>> +diff --git a/Bundles/ui/guiQml/CMakeLists.txt b/Bundles/ui/guiQml/CMakeLists.txt
>> +index 42c008e..7f9c228 100644
>> +--- a/Bundles/ui/guiQml/CMakeLists.txt
>> ++++ b/Bundles/ui/guiQml/CMakeLists.txt
>> +@@ -1,6 +1,6 @@
>> + fwLoadProperties()
>> + 
>> +-find_package(Boost QUIET COMPONENTS Regex REQUIRED)
>> ++find_package(Boost QUIET COMPONENTS regex REQUIRED)
>> + find_package(Qt5 QUIET COMPONENTS Core Gui Quick Qml QuickControls2 REQUIRED)
>> + 
>> + 
>> +diff --git a/Bundles/ui/guiQt/CMakeLists.txt b/Bundles/ui/guiQt/CMakeLists.txt
>> +index 3aff5d1..ff52b89 100644
>> +--- a/Bundles/ui/guiQt/CMakeLists.txt
>> ++++ b/Bundles/ui/guiQt/CMakeLists.txt
>> +@@ -1,6 +1,6 @@
>> + fwLoadProperties()
>> + 
>> +-find_package(Boost QUIET COMPONENTS Regex REQUIRED)
>> ++find_package(Boost QUIET COMPONENTS regex REQUIRED)
>> + find_package(Qt5 QUIET COMPONENTS Core Gui Widgets REQUIRED)
>> + 
>> + 
>> diff --git a/debian/patches/series b/debian/patches/series
>> index bcd8be4b..98f20a36 100644
>> --- a/debian/patches/series
>> +++ b/debian/patches/series
>> @@ -4,3 +4,4 @@ fix_version_getter.patch
>>  fix_launcher_library_path.patch
>>  fix_dcmtk_scp_cfg.patch
>>  revert_qVTK_widget.patch
>> +0007-Fix-FTBFS-with-Boost-1.71.patch
>> -- 
>> 2.26.0.rc2
>>
>
>
>
>
>
>> _______________________________________________
>> Debian-med-packaging mailing list
>> Debian-med-packaging at alioth-lists.debian.net
>> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging
>
-- 
Flavien BRIDAULT
Software Development Director

fbridault at ircad.fr
+33 (0)3 88 119 201

IRCAD
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ <http://www.ircad.fr/>