[Debian-med-packaging] Bug#960294: tigr-glimmer does not trap errors from make

[Helmut Grohne]

Source: tigr-glimmer
Version: 3.02b-3
Tags: upstream
Severity: serious
Justification: policy 4.6

The upstream makefiles of tigr-glimmer do not trap errors from commands
run via make. Doing so is a policy section 4.6 violation and thus
deserves rc severity. Particular occasions:

 * src/c_make.gen macro dosubdirs around line 416: Runs a sub make
   without trapping its error code. Consider adding "set -e" to the
   start.
 * src/c_make.gen %.o:%.c rule around line 315: Runs the C compiler
   without trapping its error code. Consider adding "set -e" to the
   start.

This is not a theoretical issue. In case of a compilation failure (as
happens when attempting to cross build tigr-glimmer), make continues the
dh_auto_build is considered successful despite not having built the
required objects. As such this issue can cause undetectable misbuilds
even when building natively.

Helmut