[Debian-med-packaging] Bug#960294: closed by Debian FTP Masters <ftpmaster at ftp-master.debian.org> (reply to Etienne Mollier <etienne.mollier at mailoo.org>) (Bug#960294: fixed in tigr-glimmer 3.02b-4)

[Helmut Grohne]

Control: reopen -1

On Mon, May 11, 2020 at 08:51:11PM +0000, Debian Bug Tracking System wrote:
>   * Reinforce Makefiles error checking.  Closes: #960294

I fear you only implemented a partial solution (based on my
recommendation here). In my tests, failures still go unchecked. I think
at least one issue is the linker rule in src/c_make.gen starting with
line 359. You added "set -e" there. The command snippet has an outer if
branch to select the linker (C vs C++) and an inner branch that removes
the linked file on failure. Unfortunately, the failure path does not
propagate the failure, because it is already captured in the if. Thus
swallowing errors. I didn't see this when writing my bug report either.

Beyond this, I strongly recommend implementing verbose build logs. The
issue would have been much easier to spot with verbose build logs. Build
logs have been a release goal[1]. Building verbosely is also recommended
by the Debian policy section 4.9. Unfortunately, the build system at
hand doesn't make this possible without patching.

Helmut

[1] https://wiki.debian.org/ReleaseGoals/VerboseBuildLogs