[Debian-med-packaging] Bug#960634: nanopolish: FTBFS on ppc64el (as well as ppc64 and powerpc), enumerator conflict

[Barry Arndt]

Source: nanopolish
Version: 0.13.2-1
Severity: normal
Tags: ftbfs
Justification: fails to build from source (but built successfully in the 
past) on arch ppc64el
 
-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: ppc64el (ppc64le)
Kernel: Linux 5.4.0-3-powerpc64le (SMP w/80 CPU cores)

nanopolish FTBFS on ppc64el:
https://buildd.debian.org/status/fetch.php?pkg=nanopolish&arch=ppc64el&ver=0.13.2-1&stamp=1588529870&raw=0 



nanopolish-0.13.2/src/nanopolish_squiggle_read.h contains the following 
enumeration:
 
enum PoreType
{
    PT_UNKNOWN = 0,
    PT_R7,
    PT_R9,
};
 
Enumerators PT_R7 and PT_R9 are both already defined elsewhere, which 
conflicts with this package and causes FTBFS in ppc64el.  (I'm not sure 
where PT_R7 and PT_R9 are already defined.  A quick grep of kernel source 
shows several in /usr/src/linux-xx/arch as well as /usr/lib.)
 
I verified that changing those names (PT_R7 and PT_R9) in the enumeration 
and corresponding code fixes the problem in ppc64el and allows it to build 
successfully.  Based on the build log files for ppc64 and powerpc, this 
change should fix FTBFS for those as well. 
 
I did not include a patch.  Since this problem could be fixed in several 
different ways, including the possibility of changing enumerator names, 
the maintainer might want it to match already established conventions.
 
A minor nit, removing the comma after PT_R9 would make the code a little 
more standard and match the rest of the enums in that .h file.
 
Barry Arndt
 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20200514/5c5893db/attachment.html>