[Debian-med-packaging] Bug#974570: ismrmrd: missing libpugi-dev runtime dependency

[Gianfranco Costamagna]

Hello, feel free to push your way to fix it!

I tested with dpkg-buildpackage -A and dpkg-buildpackage -B and it was fine, and also was fine my Ubuntu upload


https://launchpad.net/ubuntu/+source/ismrmrd/1.4.2.1-5~build1

So, I hope everything is fine now
(my biggest concern was to avoid accidentally drop files in the binaries)

G.



Il giovedì 12 novembre 2020, 13:58:52 CET, Andreas Tille <tille at debian.org> ha scritto: 





Hi Gianfranco,

thanks a lot for the fix (I had some race condition with another
way to fix it but your's is fine as well) and specifically to also
fix #974570.

I'll upload once my local build has finished.

Kind regards

      Andreas.

On Thu, Nov 12, 2020 at 01:23:51PM +0100, Gianfranco Costamagna wrote:
> Hello,
> 
> 
> I fixed and pushed on git the arch:all/arch:any builds and autopkgtests
> 
> commit d2d320434f30ecefc1ed8b88c0dc89c74b92b64d (HEAD -> master, origin/master, origin/HEAD)
> Author: Gianfranco Costamagna <costamagnagianfranco at yahoo.it>
> Date:  Thu Nov 12 13:22:27 2020 +0100
> 
>    Update changelog
> 
> :100644 100644 b617ae1 824ae5c M        debian/changelog
> 
> commit eb9a0d0fb17104829fb95e96446d180e49a4e916
> Author: Gianfranco Costamagna <costamagnagianfranco at yahoo.it>
> Date:  Thu Nov 12 13:21:50 2020 +0100
> 
>    Really fix arc:all and arch:any builds
> 
> :100755 100755 7300b9e 7c27cff M        debian/rules
> 
> commit 662b5b1fdc1b1b098149fed3a227d9d5950c5d4e
> Author: Gianfranco Costamagna <costamagnagianfranco at yahoo.it>
> Date:  Thu Nov 12 13:21:17 2020 +0100
> 
>    Add a runtime dependency on libpugixml-dev to fix autopkgtest failure (Closes: #974570)
> 
> :100644 100644 f9b2605 cd950bd M        debian/control
> 
> 
> Please have another look and upload if possible :)
> 
> G.
> On Thu, 12 Nov 2020 12:56:09 +0100 Gianfranco Costamagna <locutusofborg at debian.org> wrote:
> > Source: ismrmrd
> > Version: 1.4.2.1-4
> > Severity: serious
> > tags: patch
> > 
> > Hello, autopkgtests fails because of:
> > cmake ../../ismrmrd-1.4.2.1/examples/c/
> > -- Could NOT find PugiXML (missing: PugiXML_DIR)
> > CMake Error at /usr/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
> >  By not providing "FindPugiXML.cmake" in CMAKE_MODULE_PATH this project has
> >  asked CMake to find a package configuration file provided by "PugiXML", but
> >  CMake did not find one.
> > 
> >  Could not find a package configuration file provided by "PugiXML" with any
> >  of the following names:
> > 
> >    PugiXMLConfig.cmake
> >    pugixml-config.cmake
> > 
> >  Add the installation prefix of "PugiXML" to CMAKE_PREFIX_PATH or set
> >  "PugiXML_DIR" to a directory containing one of the above files.  If
> >  "PugiXML" provides a separate development package or SDK, be sure it has
> >  been installed.
> > Call Stack (most recent call first):
> >  /usr/lib/cmake/ISMRMRD/ISMRMRDConfig.cmake:74 (find_dependency)
> >  CMakeLists.txt:6 (find_package)
> > 
> > 
> > -- Configuring incomplete, errors occurred!
> > 
> > 
> > looks like the dev package should also depend on pugixml-dev
> > 
> > --- control.old    2020-11-12 12:55:48.292055695 +0100
> > +++ debian/control    2020-11-12 12:55:57.039998908 +0100
> > @@ -44,6 +44,7 @@ Multi-Arch: same
> >  Section: libdevel
> >  Depends: ${misc:Depends},
> >          libhdf5-dev,
> > +        libpugixml-dev,
> >          libismrmrd1.4 (= ${binary:Version})
> >  Suggests: libismrmrd-doc
> >  Description: development files for ISMRMRD
> > 
> > 
> > G.

> > 
> > 
> 
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging

-- 
http://fam-tille.de