[Debian-med-packaging] Bug#973431: jellyfish ftbfs when built with -O3

[Matthias Klose]

Package: src:jellyfish
Version: 2.3.0-6
Severity: important
Tags: sid bullseye ftbfs

jellyfish ftbfs when built with -O3. Note that the error messages are hidden by
libtool ...

$ g++ -DHAVE_CONFIG_H -I. -Wall -Wnon-virtual-dtor -I. -I./include -Wdate-time
-D_FORTIFY_SOURCE=2 -Werror -std=c++11 -g -O3
-fdebug-prefix-map=/home/ubuntu/jellyfish-2.3.0=. -fstack-protector-strong
-Wformat -Werror=format-security -c lib/jsoncpp.cpp -o lib/jsoncpp.o
In file included from /usr/include/c++/10/vector:72,
                 from ./include/jellyfish/json.h:328,
                 from lib/jsoncpp.cpp:76:
/usr/include/c++/10/bits/vector.tcc: In member function ‘void std::vector<_Tp,
_Alloc>::_M_realloc_insert(std::vector<_Tp, _Alloc>::iterator, _Args&& ...)
[with _Args = {Json::PathArgument}; _Tp = Json::PathArgument; _Alloc =
std::allocator<Json::PathArgument>]’:
/usr/include/c++/10/bits/vector.tcc:426:7: note: the layout of aggregates
containing vectors with 8-byte alignment has changed in GCC 5
  426 |       vector<_Tp, _Alloc>::
      |       ^~~~~~~~~~~~~~~~~~~
In member function ‘bool Json::Value::CZString::operator==(const
Json::Value::CZString&) const’,
    inlined from ‘Json::Value& Json::Value::operator[](Json::Value::ArrayIndex)’
at lib/jsoncpp.cpp:2618:51:
lib/jsoncpp.cpp:1737:20: error: argument 2 null where non-null expected
[-Werror=nonnull]
 1737 |       return strcmp( cstr_, other.cstr_ ) == 0;
      |              ~~~~~~^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/10/cstring:42,
                 from lib/jsoncpp.cpp:203:
/usr/include/string.h: In member function ‘Json::Value&
Json::Value::operator[](Json::Value::ArrayIndex)’:
/usr/include/string.h:140:12: note: in a call to function ‘int strcmp(const
char*, const char*)’ declared here
  140 | extern int strcmp (const char *__s1, const char *__s2)
      |            ^~~~~~
cc1plus: all warnings being treated as errors