[Debian-med-packaging] Bug#984200: libpdb-redo: ftbfs with GCC-11

[Matthias Klose]

Package: src:libpdb-redo
Version: 1.0.2-2
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/libpdb-redo_1.0.2-2_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
/usr/include/cif++/Cif++.hpp:461:50: error: ‘optional’ is not a member of ‘std’
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                  ^~~~~~~~
/usr/include/cif++/Cif++.hpp:41:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’?
   40 | #include "cif++/CifUtils.hpp"
  +++ |+#include <optional>
   41 | 
/usr/include/cif++/Cif++.hpp:461:59: error: template argument 1 is invalid
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                           ^
/usr/include/cif++/Cif++.hpp:461:60: error: expected unqualified-id before ‘>’ token
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                            ^~
In file included from /usr/include/cif++/Compound.hpp:35,
                 from /usr/include/cif++/Structure.hpp:33,
                 from include/pdb-redo/ClipperWrapper.hpp:30,
                 from src/ClipperWrapper.cpp:29:
/usr/include/cif++/Cif++.hpp:461:50: error: ‘optional’ is not a member of ‘std’
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                  ^~~~~~~~
/usr/include/cif++/Cif++.hpp:41:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’?
   40 | #include "cif++/CifUtils.hpp"
  +++ |+#include <optional>
   41 | 
/usr/include/cif++/Cif++.hpp:461:59: error: template argument 1 is invalid
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                           ^
/usr/include/cif++/Cif++.hpp:461:60: error: expected unqualified-id before ‘>’ token
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                            ^~
In file included from src/BondMap.cpp:37:
/usr/include/cif++/Cif++.hpp:461:50: error: ‘optional’ is not a member of ‘std’
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                  ^~~~~~~~
/usr/include/cif++/Cif++.hpp:41:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’?
   40 | #include "cif++/CifUtils.hpp"
  +++ |+#include <optional>
   41 | 
/usr/include/cif++/Cif++.hpp:461:59: error: template argument 1 is invalid
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                           ^
/usr/include/cif++/Cif++.hpp:461:60: error: expected unqualified-id before ‘>’ token
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                            ^~
In file included from /usr/include/cif++/Compound.hpp:35,
                 from /usr/include/cif++/Structure.hpp:33,
                 from include/pdb-redo/DistanceMap.hpp:33,
                 from src/DistanceMap.cpp:34:
/usr/include/cif++/Cif++.hpp:461:50: error: ‘optional’ is not a member of ‘std’
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                  ^~~~~~~~
/usr/include/cif++/Cif++.hpp:34:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’?
   33 | #include <regex>
  +++ |+#include <optional>
   34 | #include <iostream>
/usr/include/cif++/Cif++.hpp:461:59: error: template argument 1 is invalid
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                           ^
/usr/include/cif++/Cif++.hpp:461:60: error: expected unqualified-id before ‘>’ token
  461 |         struct ItemReference::item_value_as<std::optional<T>>
      |                                                            ^~
make[1]: *** [GNUmakefile:175: obj/AtomShape.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [GNUmakefile:175: obj/ClipperWrapper.lo] Error 1
make[1]: *** [GNUmakefile:175: obj/DistanceMap.lo] Error 1
make[1]: *** [GNUmakefile:175: obj/BondMap.lo] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:12: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2