[Debian-med-packaging] Bug#985071: smalt: native FTBFS with DEB_BUILD_OPTIONS=nocheck

[Nilesh Patra]

Package: smalt
Version: 0.7.6-9
Severity: important
X-Debbugs-Cc: nilesh at debian.org

Dear Maintainer,

On running with NOCHECK build opts and profile nocheck enabled, smalt
Fails to build from source with:

dh binary
   dh_testroot
   dh_prep
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
# upstream install does install more files than needed
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_install-indep
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_install
# fix path to smalt executable in examples
for py in `ls test/*.py` ; do \
    sed 's#PROGNAM = "../src/smalt"#PROGNAM = "/usr/bin/smalt"#' ${py} > debian/smalt-examples/usr/share/doc/smalt/${py} ; \
done
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_install -Nsmalt-examples
dh_install: warning: Cannot find (any matches for) "test/sequenceReverseComplement_test" (tried in ., debian/tmp)

dh_install: warning: smalt missing files: test/sequenceReverseComplement_test
dh_install: error: missing files, aborting
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

This is because smalt tried to install test/sequenceReverseComplement_test which will only be generated when
tests are run -- making this fragile when they are not.
Please consider adding a check for nocheck profile, and install this
file *only* when there is no nocheck.

Cheers,
Nilesh

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect

Versions of packages smalt depends on:
ii  libbambamc0  0.0.50-3
ii  libc6        2.31-3
ii  zlib1g       1:1.2.11.dfsg-2

smalt recommends no packages.

smalt suggests no packages.

-- no debconf information