[Debian-med-packaging] Bug#999887: dcmtk FTCBFS: uses TRY_RUN check for signedness of char

[Helmut Grohne]

Control: tags -1 - fixed-upstream

Hi Mathieu,

On Fri, Nov 19, 2021 at 02:22:05PM +0100, Mathieu Malaterre wrote:
> On Thu, Nov 18, 2021 at 6:24 AM Helmut Grohne <helmut at subdivi.de> wrote:
> > dcmtk fails to cross build from source, because it uses a TRY_RUN check
> [...]
> 
> Turns out this has been integrated directly upstream:
> 
> * http://git.dcmtk.org/?p=dcmtk.git;a=commitdiff;h=99849fffe1771096a28e6ca6cae60017b8bfa72b

I think the upstream solution is not as good as mine, because it
requires you the user to provide the check result. Other than that, the
upstream solution is more complete and covers more TRY_RUN. Maybe you
could propose my patch upstream as a further improvement?

With the upstream patch, you'll have to adapt the debian packaging and
pass the relevant flags given in the commit message. Doing so would be a
continuous maintenance effort (both in terms of added checks and in
terms of added architectures). For that reason, I recommend pursuing my
approach as a means to reduce the long-term maintenance cost.

Given that the upstream fix is incomplete from a debian pov (you also
need to update debian/rules), I'm removing the fixed-upstream tag.

Helmut