[Debian-med-packaging] Bug#997180: samtools: FTBFS: bam_tview_curses.c:88:5: error: format not a string literal and no format arguments [-Werror=format-security]

[Lucas Nussbaum]

Source: samtools
Version: 1.13-2
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> gcc -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I.  -I./lz4 -frelease  -Wdate-time -D_FORTIFY_SOURCE=2 -c -o bam_tview_curses.o bam_tview_curses.c
> cc1: warning: command-line option ‘-frelease’ is valid for D but not for C
> bam_tview_curses.c: In function ‘curses_mvprintw’:
> bam_tview_curses.c:88:5: error: format not a string literal and no format arguments [-Werror=format-security]
>    88 |     mvprintw(y,x,str);
>       |     ^~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:142: bam_tview_curses.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2021/10/23/samtools_1.13-2_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.