[Debian-med-packaging] Bug#997283: orthanc-wsi: FTBFS: OrthancHttpConnection.cpp:69:21: error: cannot convert ‘const string’ {aka ‘const std::__cxx11::basic_string<char>’} to ‘Orthanc::HttpClient::IRequestBody&’

[Lucas Nussbaum]

Source: orthanc-wsi
Version: 1.0-3
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> /usr/bin/c++ -DORTHANC_ENABLE_LOGGING_PLUGIN=0 -DORTHANC_OPENJPEG_MAJOR_VERSION=2 -DORTHANC_WSI_VERSION=\"1.0\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE=1 -I/<<PKGBUILDDIR>>/BuildApplications/AUTOGENERATED -I/usr/include/jsoncpp -I/usr/include/orthanc-framework -I/usr/include/openjpeg-2.1 -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wno-long-long -Wno-variadic-macros -std=gnu++11 -MD -MT CMakeFiles/OrthancWSIFramework.dir/<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp.o -MF CMakeFiles/OrthancWSIFramework.dir/<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp.o.d -o CMakeFiles/OrthancWSIFramework.dir/<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp.o -c /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp
> /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp: In member function ‘virtual void OrthancStone::OrthancHttpConnection::RestApiPost(std::string&, const string&, const string&)’:
> /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp:69:21: error: cannot convert ‘const string’ {aka ‘const std::__cxx11::basic_string<char>’} to ‘Orthanc::HttpClient::IRequestBody&’
>    69 |     client_.SetBody(body);
>       |                     ^~~~
>       |                     |
>       |                     const string {aka const std::__cxx11::basic_string<char>}
> In file included from /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.h:28,
>                  from /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp:23:
> /usr/include/orthanc-framework/HttpClient.h:154:32: note:   initializing argument 1 of ‘void Orthanc::HttpClient::SetBody(Orthanc::HttpClient::IRequestBody&)’
>   154 |     void SetBody(IRequestBody& body);
>       |                  ~~~~~~~~~~~~~~^~~~
> /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp: In member function ‘virtual void OrthancStone::OrthancHttpConnection::RestApiPut(std::string&, const string&, const string&)’:
> /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp:82:21: error: cannot convert ‘const string’ {aka ‘const std::__cxx11::basic_string<char>’} to ‘Orthanc::HttpClient::IRequestBody&’
>    82 |     client_.SetBody(body);
>       |                     ^~~~
>       |                     |
>       |                     const string {aka const std::__cxx11::basic_string<char>}
> In file included from /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.h:28,
>                  from /<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp:23:
> /usr/include/orthanc-framework/HttpClient.h:154:32: note:   initializing argument 1 of ‘void Orthanc::HttpClient::SetBody(Orthanc::HttpClient::IRequestBody&)’
>   154 |     void SetBody(IRequestBody& body);
>       |                  ~~~~~~~~~~~~~~^~~~
> make[4]: *** [CMakeFiles/OrthancWSIFramework.dir/build.make:565: CMakeFiles/OrthancWSIFramework.dir/<<PKGBUILDDIR>>/Resources/Orthanc/Stone/OrthancHttpConnection.cpp.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2021/10/23/orthanc-wsi_1.0-3_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.