[Debian-med-packaging] Bug#1010358: ugene: Fix for non-constant SIGSTKSZ

[Heinrich Schuchardt]

Package: ugene
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu kinetic ubuntu-patch

Dear Maintainer,

ugene 40.1+dfsg-1 fails to build on Ubuntu.

  * Fix for non-constant SIGSTKSZ (LP: #1970417) 
  * Build on amd64 only.

Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.15.0-27-generic (SMP w/32 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru ugene-40.1+dfsg/debian/control ugene-40.1+dfsg/debian/control
--- ugene-40.1+dfsg/debian/control	2021-10-19 12:55:46.000000000 +0200
+++ ugene-40.1+dfsg/debian/control	2022-04-26 14:25:30.000000000 +0200
@@ -1,9 +1,9 @@
 Source: ugene
-Maintainer: Debian Med Packaging Team <debian-med-packaging at lists.alioth.debian.org>
+Maintainer: Maintainer: Debian Med Packaging Team <debian-med-packaging at lists.alioth.debian.org>
 Uploaders: Steffen Moeller <moeller at debian.org>,
            Andreas Tille <tille at debian.org>,
            Olivier Sallou <osallou at debian.org>
-Section: non-free/science
+Section: multiverse/science
 XS-Autobuild: yes
 Priority: optional
 Build-Depends: qtbase5-dev,
@@ -30,7 +30,7 @@
 Rules-Requires-Root: no
 
 Package: ugene
-Architecture: any
+Architecture: amd64
 Depends: ${shlibs:Depends},
          ugene-data,
          ${misc:Depends}
diff -Nru ugene-40.1+dfsg/debian/patches/Fix-for-non-constant-SIGSTKSZ.patch ugene-40.1+dfsg/debian/patches/Fix-for-non-constant-SIGSTKSZ.patch
--- ugene-40.1+dfsg/debian/patches/Fix-for-non-constant-SIGSTKSZ.patch	1970-01-01 01:00:00.000000000 +0100
+++ ugene-40.1+dfsg/debian/patches/Fix-for-non-constant-SIGSTKSZ.patch	2022-04-26 14:24:36.000000000 +0200
@@ -0,0 +1,32 @@
+From: David Faure <david.faure at kdab.com>
+Date: Wed, 15 Dec 2021 22:26:40 +0100
+Subject: [PATCH] Fix for non-constant SIGSTKSZ
+
+On glibc > 2.33, `SIGSTKSZ` might not be constant (in which case
+it expands to a call to `sysconf` which returns a `long int`); see
+https://sourceware.org/pipermail/libc-alpha/2020-October/118513.html
+
+Pass unsigned explicitly to std::max, to avoid relying on template
+argument deduction. This works both with the old-style constant
+`SIGSTKSZ` and the new configurable one.
+
+Initially based on https://chromium-review.googlesource.com/c/2776379
+
+Change-Id: I9fc95337f973e871b84735ce822b5e11ba73ea8c
+Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3340721
+Reviewed-by: Mark Mentovai <mark at chromium.org>
+---
+ src/client/linux/handler/exception_handler.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/src/libs_3rdparty/breakpad/src/client/linux/handler/exception_handler.cc
++++ b/src/libs_3rdparty/breakpad/src/client/linux/handler/exception_handler.cc
+@@ -141,7 +141,7 @@
+   // SIGSTKSZ may be too small to prevent the signal handlers from overrunning
+   // the alternative stack. Ensure that the size of the alternative stack is
+   // large enough.
+-  static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
++  const unsigned kSigStackSize = std::max<unsigned>(16384, SIGSTKSZ);
+ 
+   // Only set an alternative stack if there isn't already one, or if the current
+   // one is too small.
diff -Nru ugene-40.1+dfsg/debian/patches/series ugene-40.1+dfsg/debian/patches/series
--- ugene-40.1+dfsg/debian/patches/series	2021-10-19 12:55:46.000000000 +0200
+++ ugene-40.1+dfsg/debian/patches/series	2022-04-26 14:25:30.000000000 +0200
@@ -3,3 +3,4 @@
 do_not_build_phylip.patch
 # only partly addressed by upstream
 use_debian_sqlite.patch
+Fix-for-non-constant-SIGSTKSZ.patch