[Debian-med-packaging] Bug#1017325: theseus: FTBFS: DLTutils.c:427:11: error: pointer ‘outfile’ used after ‘fclose’ [-Werror=use-after-free]

[Lucas Nussbaum]

Source: theseus
Version: 3.3.0-11
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20220813 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> /usr/bin/gcc -O3 -ffast-math -fstrict-aliasing -funroll-loops -fomit-frame-pointer -Wall -Werror -pedantic -std=c99 -Wno-unused-result -Wformat-truncation=0 -pthread  -c DLTutils.c
> DLTutils.c: In function ‘linefix’:
> DLTutils.c:427:11: error: pointer ‘outfile’ used after ‘fclose’ [-Werror=use-after-free]
>   427 |     return(outfile);
>       |           ^
> DLTutils.c:425:5: note: call to ‘fclose’ here
>   425 |     fclose(outfile);
>       |     ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [Makefile:10: DLTutils.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2022/08/13/theseus_3.3.0-11_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220813;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220813&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.