[Debian-med-packaging] Bug#1026297: unifrac-tools: Frequent parallel FTBFS

[Adrian Bunk]

Source: unifrac-tools
Version: 1.1.3-1
Severity: serious
Tags: ftbfs patch
Control: block 1021542 by -1

https://tests.reproducible-builds.org/debian/history/unifrac-tools.html
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/unifrac-tools.html
https://buildd.debian.org/status/logs.php?pkg=unifrac-tools&arch=arm64

...
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
...
h5c++ -Wdate-time -D_FORTIFY_SOURCE=2 -fopenmp -Wextra -Wno-unused-parameter -Wall  -std=c++14 -pedantic -I. -O4 -fPIC -L/<<PKGBUILDDIR>>/debian/tmp/usr/lib  faithpd.cpp -o faithpd tree.o biom.o unifrac_internal.o unifrac_cmp_cpu.o unifrac.o cmd.o skbio_alt.o api.o -lhdf5_cpp -llz4 -llapacke -lblas -lpthread
h5c++ -Wdate-time -D_FORTIFY_SOURCE=2 -fopenmp -Wextra -Wno-unused-parameter -Wall  -std=c++14 -pedantic -I. -O4 -fPIC -L/<<PKGBUILDDIR>>/debian/tmp/usr/lib  faithpd.cpp -o faithpd tree.o biom.o unifrac_internal.o unifrac_cmp_cpu.o unifrac.o cmd.o skbio_alt.o api.o -lhdf5_cpp -llz4 -llapacke -lblas -lpthread
/usr/bin/ld: /usr/lib/gcc/aarch64-linux-gnu/12/../../../aarch64-linux-gnu/Scrt1.o: in function `_start':
(.text+0x1c): undefined reference to `main'
/usr/bin/ld: (.text+0x20): undefined reference to `main'
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:108: faithpd] Error 1


The problem is the toplevel Makefile calling make in src/ up to three
times in parallel during the build.

The easiest workaround is:

--- debian/rules.old	2022-12-17 22:53:06.643268060 +0000
+++ debian/rules	2022-12-17 22:53:11.403264194 +0000
@@ -7,7 +7,7 @@
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 
 %:
-	dh $@
+	dh $@ --no-parallel
 
 override_dh_auto_build:
 	mkdir -p $(CURDIR)/debian/tmp/usr/bin