[Debian-med-packaging] Bug#1003808: libvcflib: reproducible-builds: BuildId differences triggered by RPATH

[Andreas Tille]

Hi Vagrant

are you sure you picked the right code to patch?  The code in Git[1]
is very different from the chunk your patch claims to replace.  While
I could easily add -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON to dh_auto_configure
but I wanted to make sure that there is no other package you intended
to fix that way.

Kind regards

      Andreas.

[1] https://salsa.debian.org/med-team/libvcflib/-/blob/master/debian/rules#L22

Am Sat, Jan 15, 2022 at 05:48:50PM -0800 schrieb Vagrant Cascadian:
> Source: libvcflib
> Severity: normal
> Tags: patch
> User: reproducible-builds at lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org
> 
> The RPATH contains the build path resulting in different buildid:
> 
>   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libvcflib.html
> 
> The attached patch to debian/rules passes
> -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
> which should use a relative path for RPATH.
> 
> Alternately, updating the packaging to debhelper compat level 14 should
> fix this, although it is currently an experimental compat level.
> 
> 
> With this patch applied, libvcflib should build reproducibly on
> tests.reproducible-builds.org!
> 
> 
> Thanks for maintaining libvcflib!
> 
> 
> live well,
>   vagrant

> From 28fa4ee3a093404e5bb38df628660a8c004f3666 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant at reproducible-builds.org>
> Date: Sat, 15 Jan 2022 23:00:25 +0000
> Subject: [PATCH] debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
>  dh_auto_configure override.
> 
> This avoids embedding the full path in RPATH, which triggers BuildId
> differences.
> 
> https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
> ---
>  debian/rules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian/rules b/debian/rules
> index c66b57f..03cb3e7 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -20,6 +20,7 @@ endif
>  override_dh_auto_configure:
>  	dh_auto_configure -- \
>  		-DDOCS=$(BUILDDOC) \
> +		-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON \
>  		-DPYTHON=ON
>  
>  # https://github.com/AcademySoftwareFoundation/Imath/issues/226
> -- 
> 2.34.1
> 




> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging


-- 
http://fam-tille.de