[Debian-med-packaging] Bug#1014582: Build failure with googletest 1.12

[Mattias Ellert]

Source: seqan3
Version: 3.2.0+ds-1
Severity: serious

The package fails to build in unstable due to a failing test.
The failure is due to a change in googletest 1.12


7451/8534 Test #7451: test/pretty_printing_test::pretty_printing.std_output ..........................................................................................................................................................................................................................................................................................................................***Failed    0.16 sec
Running main() from /usr/src/googletest/googletest/src/gtest_main.cc
Note: Google Test filter = pretty_printing.std_output
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from pretty_printing
[ RUN      ] pretty_printing.std_output
/tmp/autopkgtest-lxc.y_bdsw4i/downtmp/autopkgtest_tmp/unit/test/pretty_printing_test.cpp:70: Failure
Expected equality of these values:
  gtest_str(std::nullopt)
    Which is: "(nullopt)"
  "<VALUELESS_OPTIONAL>"s
    Which is: "<VALUELESS_OPTIONAL>"
[  FAILED  ] pretty_printing.std_output (0 ms)
[----------] 1 test from pretty_printing (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] pretty_printing.std_output

 1 FAILED TEST


The following tests FAILED:
	7451 - test/pretty_printing_test::pretty_printing.std_output (Failed)


The fix is something like this:


diff -ur seqan3-3.2.0+ds/test/unit/test/pretty_printing_test.cpp seqan3-3.2.0+ds.new/test/unit/test/pretty_printing_test.cpp
--- seqan3-3.2.0+ds/test/unit/test/pretty_printing_test.cpp	2022-07-08 10:35:03.984000000 +0200
+++ seqan3-3.2.0+ds.new/test/unit/test/pretty_printing_test.cpp	2022-07-08 10:22:40.124000000 +0200
@@ -67,7 +67,11 @@
     EXPECT_EQ(gtest_str(std::vector<std::vector<int>>{{0, 1}, {2, 3}, {1, 2}, {0}}), "[[0,1],[2,3],[1,2],[0]]"s);
     EXPECT_EQ(debug_str(std::vector<std::vector<int>>{{0, 1}, {2, 3}, {1, 2}, {0}}), "[[0,1],[2,3],[1,2],[0]]"s);
 
+#if [condition that indicates googletest version is >= 1.12]
+    EXPECT_EQ(gtest_str(std::nullopt), "(ynullopt)"s);
+#else
     EXPECT_EQ(gtest_str(std::nullopt), "<VALUELESS_OPTIONAL>"s);
+#endif
     EXPECT_EQ(debug_str(std::nullopt), "<VALUELESS_OPTIONAL>"s);
 }
 

I don't know the best way to define the [condition that indicates
googletest version is >= 1.12]

The seqan build is used as a autopkgtest for googletest, so this
failure is blocking the migration to testing for the googletest
package. (Can this be overridden somehow, if seqan is not fixed?)

	Mattias


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 874 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20220708/20aacb37/attachment-0001.sig>