[Debian-med-packaging] Bug#1014626: primer3: completely broken debian/rules handling of big-endian archs

[Steve Langasek]

Package: primer3
Version: 2.6.1-2
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu kinetic ubuntu-patch

Dear maintainers,

The primer3 package contains code in debian/rules whose purpose is to
monkeypatch the testsuite on big-endian architectures to disable certain
tests.

Instead, it mangles the files under test/ completely on big-endian archs,
causing the testsuite to fail to be run.

It seems that somewhere along the way it was decided to remove s390x
binaries from the Debian archive rather than fix debian/rules.  But the code
remains.

Attached is a patch that fixes the sed commands being used to mangle the
testsuite, which would let the package build on s390x again.

Please either apply this patch, or else drop the mangling code from
debian/rules to let the s390x build fail cleanly.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru primer3-2.6.1/debian/rules primer3-2.6.1/debian/rules
--- primer3-2.6.1/debian/rules	2022-02-19 08:57:05.000000000 -0800
+++ primer3-2.6.1/debian/rules	2022-07-08 22:18:02.000000000 -0700
@@ -29,9 +29,8 @@
 	cp -a test/Makefile test/Makefile~
 	# exclude tests known to fail on big endian
 	# See README.source for further explanation.
-	for tst in $(P3CORE_FAILED_TESTS) ; do sed -i "/$${tst}/d" test/p3test.pl ; done
-	sed -i "0,/$(FAILED_TESTS)/s///" test/Makefile
-	sed -i "/$(FAILED_TESTS)/,/endif/d" test/Makefile
+	for tst in $(P3CORE_FAILED_TESTS) ; do sed -i "/$${tst}.,/d" test/p3test.pl ; done
+	for tst in $(FAILED_TESTS); do sed -i "/^test:/s/$$tst//" test/Makefile; done
 endif
 	dh_auto_test --no-parallel --sourcedirectory=test
 ifneq ($(BUILDARCH),little)