[Debian-med-packaging] Bug#1023823: primer3: broken d/t/run-unit-tests handling of big-endian archs

[Lukas Märdian]

Package: primer3
Version: 2.6.1-3
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu lunar ubuntu-patch
X-Debbugs-Cc: slyon at ubuntu.com

Dear Maintainer,

The primer3 package contains code in debian/tests/run-unit-test whose
purpose is to monkeypatch the testsuite on big-endian architectures to
disable certain tests.

Instead, it mangles the files under test/ completely on big-endian archs,
causing the autopkgtest testsuite to fail to be run.

Attached is a patch that fixes the sed commands being used to mangle the
testsuite, which would let the package run autopkgtests on s390x again.

Related to: https://bugs.debian.org/1014626


Thanks for considering the patch.

Cheers, Lukas


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.15.0-50-generic (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru primer3-2.6.1/debian/tests/run-unit-test primer3-2.6.1/debian/tests/run-unit-test
--- primer3-2.6.1/debian/tests/run-unit-test	2022-07-09 10:50:59.000000000 +0200
+++ primer3-2.6.1/debian/tests/run-unit-test	2022-07-09 07:20:30.000000000 +0200
@@ -30,9 +30,8 @@
   cp -a test/Makefile test/Makefile~
   # exclude tests known to fail on big endian
   # See README.source for further explanation.
-  for tst in $P3CORE_FAILED_TESTS ; do sed -i "/$tst/d" test/p3test.pl ; done
-  sed -i "0,/$FAILED_TESTS/s///" test/Makefile
-  sed -i "/$FAILED_TESTS/,/endif/d" test/Makefile
+  for tst in $P3CORE_FAILED_TESTS ; do sed -i "/${tst}.,/d" test/p3test.pl ; done
+  for tst in $FAILED_TESTS; do sed -i "/^test:/s/$tst//" test/Makefile; done
 fi
 
 cd test/;