[Debian-med-packaging] Bug#1023738: orthanc-dicomweb FTBFS with node-axios 1.1

[Étienne Mollier]

Control: tags -1 + patch

Hi Sébastien,

orthanc-dicomweb is currently affected by a failure to build
from source (Bug#1023738).  I took the liberty to have a look,
and it seems that since axios 1.0 the dist/axios.map file is not
provided anymore.  This is causing the following cmake error:

	CMake Error at debian/ThirdPartyDownloads/JavaScriptLibraries.cmake:29 (file):
	  file COPY_FILE failed to copy
	
	    /usr/share/nodejs/axios/dist/axios.map
	
	  to
	
	    /<<PKGBUILDDIR>>/Build/javascript-libs/js/axios.min.map

Scanning through the source code, I noticed that axios.min.map
file was not used anywhere (only mention is in a cmake file
which is patched out in Debian context).  When removing the
reference this way, I got the package to build again:

-------8<--------------8<--------------8<--------------8<-------
--- a/debian/ThirdPartyDownloads/JavaScriptLibraries.cmake
+++ b/debian/ThirdPartyDownloads/JavaScriptLibraries.cmake
@@ -26,11 +26,6 @@ file(COPY_FILE
   ${JAVASCRIPT_LIBS_DIR}/js/axios.min.js
   )
 
-file(COPY_FILE
-  /usr/share/nodejs/axios/dist/axios.map
-  ${JAVASCRIPT_LIBS_DIR}/js/axios.min.map
-  )
-
 file(COPY
   ${CMAKE_SOURCE_DIR}/debian/ThirdPartyDownloads/bootstrap-vue/bootstrap-vue.min.css
   ${CMAKE_SOURCE_DIR}/debian/ThirdPartyDownloads/bootstrap-vue/bootstrap-vue.min.css.map
------->8-------------->8-------------->8-------------->8-------

Since my knowledge of the nodejs ecosystem is near zero, I'd
rather ask: would such change look sound or do you foresee any
adverse effects?

In hope this helps,
-- 
  .''`.  Étienne Mollier <emollier at debian.org>
 : :' :  gpg: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/2, please excuse my verbosity
   `-    on air: Haken - Bound By Gravity
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20221118/22f7184c/attachment.sig>