[Debian-med-packaging] Bug#1021115: unifrac-tools: Baseline violation on x86 and FTBFS everywhere else

[Adrian Bunk]

On Sun, Oct 02, 2022 at 05:13:33PM +0200, Étienne Mollier wrote:
> Hi Adrian,
> 
> Adrian Bunk, on 2022-10-02:
> > src/Makefile:
> > ...
> >         ifeq ($(PERFORMING_CONDA_BUILD),True)
> >                 CPPFLAGS += -mtune=generic
> >         else
> >                 CPPFLAGS += -mfma -march=native
> >         endif
> > ...
> > 
> > 
> > 
> > Please remove this block, it is a baseline violation on x86
> > and causes FTBFS everywhere else.
> > 
> > Please don't use the PERFORMING_CONDA_BUILD case instead:
> > -mtune=generic is already the Debian default on x86,
> > but it is not supported on some/all(?) other architectures.
> 
> Done, the PERFORMING_CONDA_BUILD variable is specific to conda
> distribution and normally not related to enabling SIMD support.
> Touching it on the debian package end would also enable a lot of
> other bits which we probably don't need or want.

I was talking about a different change that would have been wrong:

-ifeq ($(PERFORMING_CONDA_BUILD),True)
         CPPFLAGS += -mtune=generic
-else
-        CPPFLAGS += -mfma -march=native
-endif


This would have fixed the baseline violation,
but broken the build on non-x86 in a different way.


> Thanks for your report!
> 
> Have a nice day,  :)

cu
Adrian