[Debian-med-packaging] Bug#1021394: src:libcereal: FTBFS on arm, ppc64le, s390x

[Scott Talbert]

Package: src:libcereal
Version: 1.3.2+dfsg-3
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

libcereal 1.3.2+dfsg-3 FTBFS on arm, ppc64le, s390x.  This seems to be
the relevant error:

[ 22%] Building CXX object unittests/CMakeFiles/test_map.dir/map.cpp.o
cd /<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/unittests && /usr/bin/c++  -I/<<PKGBUILDDIR>>/include -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -pedantic -Wshadow -Wold-style-cast -Werror -std=gnu++11 -MD -MT unittests/CMakeFiles/test_map.dir/map.cpp.o -MF CMakeFiles/test_map.dir/map.cpp.o.d -o CMakeFiles/test_map.dir/map.cpp.o -c /<<PKGBUILDDIR>>/unittests/map.cpp
In file included from /<<PKGBUILDDIR>>/unittests/map.cpp:28:
/<<PKGBUILDDIR>>/unittests/map.hpp: In instantiation of ‘void test_map() [with IArchive = cereal::BinaryInputArchive; OArchive = cereal::BinaryOutputArchive]’:
/<<PKGBUILDDIR>>/unittests/map.cpp:34:68:   required from here
/<<PKGBUILDDIR>>/unittests/map.hpp:65:43: error: narrowing conversion of ‘random_value<char>(gen)’ from ‘std::enable_if<true, char>::type’ {aka ‘char’} to ‘signed char’ [-Werror=narrowing]
   65 |       o_esplmap.insert({random_value<char>(gen),  { random_value<int>(gen), random_value<int>(gen) }});
      |                         ~~~~~~~~~~~~~~~~~~^~~~~
/<<PKGBUILDDIR>>/unittests/map.hpp: In instantiation of ‘void test_map() [with IArchive = cereal::PortableBinaryInputArchive; OArchive = cereal::PortableBinaryOutputArchive]’:
/<<PKGBUILDDIR>>/unittests/map.cpp:39:84:   required from here
/<<PKGBUILDDIR>>/unittests/map.hpp:65:43: error: narrowing conversion of ‘random_value<char>(gen)’ from ‘std::enable_if<true, char>::type’ {aka ‘char’} to ‘signed char’ [-Werror=narrowing]
/<<PKGBUILDDIR>>/unittests/map.hpp: In instantiation of ‘void test_map() [with IArchive = cereal::XMLInputArchive; OArchive = cereal::XMLOutputArchive]’:
/<<PKGBUILDDIR>>/unittests/map.cpp:44:62:   required from here
/<<PKGBUILDDIR>>/unittests/map.hpp:65:43: error: narrowing conversion of ‘random_value<char>(gen)’ from ‘std::enable_if<true, char>::type’ {aka ‘char’} to ‘signed char’ [-Werror=narrowing]
/<<PKGBUILDDIR>>/unittests/map.hpp: In instantiation of ‘void test_map() [with IArchive = cereal::JSONInputArchive; OArchive = cereal::JSONOutputArchive]’:
/<<PKGBUILDDIR>>/unittests/map.cpp:49:64:   required from here
/<<PKGBUILDDIR>>/unittests/map.hpp:65:43: error: narrowing conversion of ‘random_value<char>(gen)’ from ‘std::enable_if<true, char>::type’ {aka ‘char’} to ‘signed char’ [-Werror=narrowing]

See buildd logs for more information.

Also, please push the 1.3.2+dfsg-3 changes to git.

Thanks,
Scott