[Debian-med-packaging] Bug#1015102: heudiconv: FTBFS: FAILED heudiconv/tests/test_heuristics.py::test_reproin_largely_smoke[--files /<<PKGBUILDDIR>>/.pybuild/cpython3_3.10_heudiconv/build/heudiconv/tests/data-reproin]

[Yaroslav Halchenko]

oh, sorry about that and thanks for the ping!

I fixed it upstream already (the bug is really in datalad), and will
look to release it asap (i.e. now) and then see if we can update package
(might need to also upload new version of dcmstack first)

On Thu, 29 Sep 2022, Nilesh Patra wrote:

> Hi Yaroslav,

> Since you are the upstream for heudiconv, could you please help fix this?

> On Sat, 16 Jul 2022 15:49:48 +0200 Lucas Nussbaum <lucas at debian.org> wrote:
> > Source: heudiconv
> > Version: 0.11.3-1
> > Severity: serious
> > Justification: FTBFS
> > Tags: bookworm sid ftbfs
> > User: lucas at debian.org
> > Usertags: ftbfs-20220716 ftbfs-bookworm

> > Hi,

> > During a rebuild of all packages in sid, your package failed to build
> > on amd64.


> > Relevant part (hopefully):

> >    dh_auto_test -O--buildsystem=pybuild
> > 	pybuild --test --test-pytest -i python{version} -p "3.9 3.10"
> > I: pybuild pybuild:300: cp -a heudiconv/tests /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9_heudiconv/build/heudiconv/
> > I: pybuild base:239: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9_heudiconv/build; python3.9 -m pytest 
> > ============================= test session starts ==============================
> > platform linux -- Python 3.9.13, pytest-7.1.2, pluggy-1.0.0
> > rootdir: /<<PKGBUILDDIR>>
> > collected 99 items / 1 skipped

> > heudiconv/external/tests/test_dlad.py .                                  [  1%]
> > heudiconv/heuristics/test_reproin.py ........                            [  9%]
> > heudiconv/tests/test_bids.py ..................................s         [ 44%]
> > heudiconv/tests/test_convert.py ..........                               [ 54%]
> > heudiconv/tests/test_dicoms.py ...                                       [ 57%]
> > heudiconv/tests/test_heuristics.py .F.........                           [ 68%]
> > heudiconv/tests/test_main.py ..............                              [ 82%]
> > heudiconv/tests/test_queue.py ...                                        [ 85%]
> > heudiconv/tests/test_regression.py sss.                                  [ 89%]
> > heudiconv/tests/test_tarballs.py .                                       [ 90%]
> > heudiconv/tests/test_utils.py .........                                  [100%]

> > =================================== FAILURES ===================================
> > _ test_reproin_largely_smoke[--files /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9_heudiconv/build/heudiconv/tests/data-reproin] _

> > tmpdir = local('/tmp/pytest-of-user42/pytest-9/test_reproin_largely_smoke___f0')
> > heuristic = 'reproin'
> > invocation = '--files /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9_heudiconv/build/heudiconv/tests/data'

> >     @pytest.mark.parametrize('heuristic', ['reproin', 'convertall'])
> >     @pytest.mark.parametrize(
> >         'invocation', [
> >             "--files %s" % TESTS_DATA_PATH,    # our new way with automated groupping
> >             "-d %s/{subject}/* -s 01-fmap_acq-3mm" % TESTS_DATA_PATH # "old" way specifying subject
> >             # should produce the same results
> >         ])
> >     @pytest.mark.skipif(Dataset is None, reason="no datalad")
> >     def test_reproin_largely_smoke(tmpdir, heuristic, invocation):
> >         is_bids = True if heuristic == 'reproin' else False
> >         arg = "--random-seed 1 -f %s -c dcm2niix -o %s" \
> >               % (heuristic, tmpdir)
> >         if is_bids:
> >             arg += " -b"
> >         arg += " --datalad "
> >         args = (
> >             arg + invocation
> >         ).split(' ')

> >         # Test some safeguards
> >         if invocation == "--files %s" % TESTS_DATA_PATH:
> >             # Multiple subjects must not be specified -- only a single one could
> >             # be overridden from the command line
> >             with pytest.raises(ValueError):
> >                 runner(args + ['--subjects', 'sub1', 'sub2'])

> >             if heuristic != 'reproin':
> >                 # if subject is not overridden, raise error
> >                 with pytest.raises(NotImplementedError):
> >                     runner(args)
> >                 return

> >         runner(args)
> >         ds = Dataset(str(tmpdir))
> >         assert ds.is_installed()
> >         assert not ds.repo.dirty
> >         head = ds.repo.get_hexsha()

> >         # and if we rerun -- should fail
> >         lgr.info(
> >             "RERUNNING, expecting to FAIL since the same everything "
> >             "and -c specified so we did conversion already"
> >         )
> >         with pytest.raises(RuntimeError):
> >             runner(args)

> >         # but there should be nothing new
> >         assert not ds.repo.dirty
> > >       assert head == ds.repo.get_hexsha()
> > E       AssertionError: assert '2c32d90c7252...452338c3a611a' == '52121805b02b...b36be77769e34'
> > E         - 52121805b02b454149686a4ae12b36be77769e34
> > E         + 2c32d90c7252c966ebdba876f6f452338c3a611a

> > /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9_heudiconv/build/heudiconv/tests/test_heuristics.py:93: AssertionError
> > ----------------------------- Captured stdout call -----------------------------
-- 
Yaroslav O. Halchenko
Center for Open Neuroscience     http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
WWW:   http://www.linkedin.com/in/yarik        

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20220929/d6aba75b/attachment-0001.sig>