[Debian-med-packaging] Bug#1047043: insighttoolkit5: Fails to build source after successful build

[Lucas Nussbaum]

Source: insighttoolkit5
Version: 5.3.0-5
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package insighttoolkit5
> dpkg-buildpackage: info: source version 5.3.0-5
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Steve M. Robbins <smr at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --builddir=BUILD
>    dh_auto_clean -O--builddir=BUILD
>    dh_autoreconf_clean -O--builddir=BUILD
>    debian/rules override_dh_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> # Modules/ThirdParty/pygccxml/src/pygccxml leaves build artifacts around
> find  Modules/ThirdParty/pygccxml/src -name __pycache__ -execdir rm -r '{}' +
> dh_clean
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building insighttoolkit5 using existing ./insighttoolkit5_5.3.0.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  insighttoolkit5-5.3.0/Insight5.3Valgrind.supp
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/insighttoolkit5_5.3.0-5.diff.MCsKiS
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/insighttoolkit5_5.3.0-5_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.