[Debian-med-packaging] Bug#1047995: king: Fails to build source after successful build

[Lucas Nussbaum]

Source: king
Version: 2.24+dfsg2-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> --------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package king
> dpkg-buildpackage: info: source version 2.24+dfsg2-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Pierre Gruet <pgt at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --with javahelper
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> mkdir -p king/plugins
> ant -buildfile king/build.xml clean
> Buildfile: /<<PKGBUILDDIR>>/king/build.xml
> 
> clean:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/king/dist
>    [delete] Deleting directory /<<PKGBUILDDIR>>/king/build
> 
> BUILD SUCCESSFUL
> Total time: 0 seconds
> ant -buildfile chiropraxis/build.xml clean
> Buildfile: /<<PKGBUILDDIR>>/chiropraxis/build.xml
> 
> clean:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/chiropraxis/dist
>    [delete] Deleting directory /<<PKGBUILDDIR>>/chiropraxis/build
>    [delete] Deleting: /<<PKGBUILDDIR>>/chiropraxis/chiropraxis.jar
> 
> BUILD SUCCESSFUL
> Total time: 0 seconds
> ant -buildfile driftwood/build.xml clean
> Buildfile: /<<PKGBUILDDIR>>/driftwood/build.xml
> 
> clean:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/driftwood/dist
>    [delete] Deleting directory /<<PKGBUILDDIR>>/driftwood/build
> 
> BUILD SUCCESSFUL
> Total time: 0 seconds
> ant -buildfile extratools/build.xml clean
> Buildfile: /<<PKGBUILDDIR>>/extratools/build.xml
> 
> clean:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/extratools/dist
>    [delete] Deleting directory /<<PKGBUILDDIR>>/extratools/build
>    [delete] Deleting: /<<PKGBUILDDIR>>/extratools/extratools.jar
> 
> BUILD SUCCESSFUL
> Total time: 0 seconds
> ant -buildfile molikin/build.xml clean
> Buildfile: /<<PKGBUILDDIR>>/molikin/build.xml
> 
> clean:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/molikin/build
> 
> BUILD SUCCESSFUL
> Total time: 0 seconds
> rm -rf king_jar
> # Removing the png icons we created from our set of DFSG-free icons
> if [ -e king/resource/king/images/Add16.png ]; then \
>         find king/resource/king/images -name "*.png" | grep -E '[A-Z][a-z]*[0-9]{2}.png' | xargs rm ; \
> fi
> # restore backups of original buildnum resources to enable building twice in a row
> for component in chiropraxis driftwood extratools king molikin ; do \
>   rm -rf $component/resource/$component/buildnum.props ; \
>   if [ -e $component/resource/$component/buildnum.props.orig ] ; then \
>     mv $component/resource/$component/buildnum.props.orig $component/resource/$component/buildnum.props ; \
>   fi ; \
> done
> find . -name "*.class" -delete
> rm -rf lib
> rm -rf king/plugins
> rm quickies/native/libnativespeed.so
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    jh_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building king using existing ./king_2.24+dfsg2.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of directory king/plugins
> dpkg-source: info: local changes detected, the modified files are:
>  king-2.24+dfsg2/king/doc/dot_king_prefs.txt
>  king-2.24+dfsg2/king/resource/META-INF/services/king.Plugin
>  king-2.24+dfsg2/king/resource/king/king_prefs
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/king_2.24+dfsg2-1.diff.A1bQkJ
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/king_2.24+dfsg2-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.