[Debian-med-packaging] Bug#1048555: mptp: Fails to build source after successful build

[Lucas Nussbaum]

Source: mptp
Version: 0.2.4-3
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ---------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package mptp
> dpkg-buildpackage: info: source version 0.2.4-3
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Nilesh Patra <npatra974 at gmail.com>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> Making distclean in src
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
> test -z "../bin/mptp" || rm -f ../bin/mptp
> test -z "libparse_utree.a libparse_rtree.a" || rm -f libparse_utree.a libparse_rtree.a
> rm -f *.o
> rm -f *.tab.c
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test -z "../bin/.dirstamp" || rm -f ../bin/.dirstamp
> rm -f ./.deps/aic.Po
> rm -f ./.deps/arch.Po
> rm -f ./.deps/auto.Po
> rm -f ./.deps/dp.Po
> rm -f ./.deps/fasta.Po
> rm -f ./.deps/hash.Po
> rm -f ./.deps/lex_rtree.Po
> rm -f ./.deps/lex_utree.Po
> rm -f ./.deps/likelihood.Po
> rm -f ./.deps/list.Po
> rm -f ./.deps/maps.Po
> rm -f ./.deps/mptp.Po
> rm -f ./.deps/multirun.Po
> rm -f ./.deps/output.Po
> rm -f ./.deps/parse_rtree.Po
> rm -f ./.deps/parse_utree.Po
> rm -f ./.deps/random.Po
> rm -f ./.deps/rtree.Po
> rm -f ./.deps/svg.Po
> rm -f ./.deps/svg_landscape.Po
> rm -f ./.deps/util.Po
> rm -f ./.deps/utree.Po
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
> Making distclean in man
> make[2]: Entering directory '/<<PKGBUILDDIR>>/man'
> test -z "" || rm -f 
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/man'
> Making distclean in completion
> make[2]: Entering directory '/<<PKGBUILDDIR>>/completion'
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/completion'
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> test -z "" || rm -f 
> rm -f config.h stamp-h1
> test . = "." || test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f config.status config.cache config.log configure.lineno config.status.lineno
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building mptp using existing ./mptp_0.2.4.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  mptp-0.2.4/man/mptp.1
>  mptp-0.2.4/src/lex_rtree.c
>  mptp-0.2.4/src/lex_utree.c
>  mptp-0.2.4/src/parse_rtree.c
>  mptp-0.2.4/src/parse_rtree.h
>  mptp-0.2.4/src/parse_utree.c
>  mptp-0.2.4/src/parse_utree.h
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/mptp_0.2.4-3.diff.dG8rv5
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/mptp_0.2.4-3_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.