[Debian-med-packaging] Bug#1049170: tree-puzzle: Fails to build source after successful build

[Lucas Nussbaum]

Source: tree-puzzle
Version: 5.3~rc16+dfsg-9
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package tree-puzzle
> dpkg-buildpackage: info: source version 5.3~rc16+dfsg-9
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Andreas Tille <tille at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --no-parallel
>    dh_auto_clean -O--no-parallel
> 	make -j1 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> Making distclean in src
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
> test -z "puzzle ppuzzle" || rm -f puzzle ppuzzle
> rm -f *.o
> rm -f *.tab.c
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f config.h stamp-h1
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> rm -f ./.deps/consensus.Po
> rm -f ./.deps/gamma.Po
> rm -f ./.deps/ml1.Po
> rm -f ./.deps/ml2.Po
> rm -f ./.deps/mlparam.Po
> rm -f ./.deps/model1.Po
> rm -f ./.deps/model2.Po
> rm -f ./.deps/ppuzzle.Po
> rm -f ./.deps/pstep.Po
> rm -f ./.deps/puzzle1.Po
> rm -f ./.deps/puzzle2.Po
> rm -f ./.deps/sched.Po
> rm -f ./.deps/treesort.Po
> rm -f ./.deps/treetest.Po
> rm -f ./.deps/util.Po
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
> Making distclean in doc
> make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
> make[3]: Entering directory '/<<PKGBUILDDIR>>/doc'
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/doc'
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
> Making distclean in data
> make[2]: Entering directory '/<<PKGBUILDDIR>>/data'
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/data'
> Making distclean in tests
> make[2]: Entering directory '/<<PKGBUILDDIR>>/tests'
> test -z "build-puzzle.log qp-pure-bin.log qp-pure-nucl.log qp-tn-nucl.log qp-hky-clock-nucl.log qp-hky-rhet-nucl.log qp-hky-rhet-clock-nucl.log qp-pure-prot.log qp-mtrev-prot.log qp-vt-prot.log qp-wag-prot.log qp-clock.log qp-jtt-prot.log qp-jtt-rhet-prot.log qp-jtt-rhet-clock-prot.log lm-pure-prot.log ut-pure-prot.log cons-pure-prot.log build-remark.log" || rm -f build-puzzle.log qp-pure-bin.log qp-pure-nucl.log qp-tn-nucl.log qp-hky-clock-nucl.log qp-hky-rhet-nucl.log qp-hky-rhet-clock-nucl.log qp-pure-prot.log qp-mtrev-prot.log qp-vt-prot.log qp-wag-prot.log qp-clock.log qp-jtt-prot.log qp-jtt-rhet-prot.log qp-jtt-rhet-clock-prot.log lm-pure-prot.log ut-pure-prot.log cons-pure-prot.log build-remark.log
> test -z "build-puzzle.trs qp-pure-bin.trs qp-pure-nucl.trs qp-tn-nucl.trs qp-hky-clock-nucl.trs qp-hky-rhet-nucl.trs qp-hky-rhet-clock-nucl.trs qp-pure-prot.trs qp-mtrev-prot.trs qp-vt-prot.trs qp-wag-prot.trs qp-clock.trs qp-jtt-prot.trs qp-jtt-rhet-prot.trs qp-jtt-rhet-clock-prot.trs lm-pure-prot.trs ut-pure-prot.trs cons-pure-prot.trs build-remark.trs" || rm -f build-puzzle.trs qp-pure-bin.trs qp-pure-nucl.trs qp-tn-nucl.trs qp-hky-clock-nucl.trs qp-hky-rhet-nucl.trs qp-hky-rhet-clock-nucl.trs qp-pure-prot.trs qp-mtrev-prot.trs qp-vt-prot.trs qp-wag-prot.trs qp-clock.trs qp-jtt-prot.trs qp-jtt-rhet-prot.trs qp-jtt-rhet-clock-prot.trs lm-pure-prot.trs ut-pure-prot.trs cons-pure-prot.trs build-remark.trs
> test -z "test-suite.log" || rm -f test-suite.log
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/tests'
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f config.status config.cache config.log configure.lineno config.status.lineno
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--no-parallel
>    dh_clean -O--no-parallel
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building tree-puzzle using existing ./tree-puzzle_5.3~rc16+dfsg.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file INSTALL, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file test-driver, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  tree-puzzle-5.3~rc16+dfsg/tests/lm-pure-prot.prot.svg
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/tree-puzzle_5.3~rc16+dfsg-9.diff.3GHFqb
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/tree-puzzle_5.3~rc16+dfsg-9_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.