[Debian-med-packaging] Bug#1039529: Bug#1039529: sight: FTBFS: /<<PKGBUILDDIR>>/libs/io/itk/helper/ProgressItkToFw.hxx:48:5: error: ‘::Create’ has not been declared

Wed Aug 23 08:54:26 BST 2023

Dear developers,

It turns out that sight FTBFS is due to a regression in itkMacro.h. This 
has been fixed upstream in 
https://github.com/InsightSoftwareConsortium/ITK/commit/7fbe8880a99ce1442b5b3e04ab05babdabe8e930. 

I could hack this in sight but this would be really tedious. This might 
break also other client code, as reported here 
https://github.com/InsightSoftwareConsortium/ITK/issues/4074/

Do you think it could be possible to add a patch for this in the 
insighttoolkit5 package ?

Thanks a lot.

*Dr. Flavien BRIDAULT*
Director of Software Development
IRCAD France & IRCAD Africa

flavien.bridault at ircad.fr <mailto:flavien.bridault-louchez at ircad.fr>
Tél. : +33 (0)3 88 119 201
		IRCAD France
http://www.ircad.fr/
http://www.ircad.africa/ <http://www.ircad.fr/>

Suivez l'IRCAD sur Facebook 
<http://www.facebook.com/pages/IRCAD/193785273990141>

*IRCAD France*
Hôpitaux Universitaires - 1, place de l'Hôpital - 67091 Strasbourg Cedex 
- FRANCE

Le 27/06/2023 à 00:10, Sebastian Ramacher a écrit :
> Source: sight
> Version: 21.1.1-3
> Severity: serious
> Tags: ftbfs sid bookworm
> Justification: fails to build from source (but built successfully in the past)
> X-Debbugs-Cc: sramacher at debian.org
>
> https://buildd.debian.org/status/fetch.php?pkg=sight&arch=amd64&ver=21.1.1-3%2Bb2&stamp=1687809257&raw=0
>
> [ 66%] Linking CXX shared library ../../../lib/x86_64-linux-gnu/libsight_module_filter_vision.so
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/modules/filter/vision && /usr/bin/cmake -E cmake_link_script CMakeFiles/module_filter_vision.dir/link.txt --verbose=1
> /usr/bin/c++ -fPIC -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,--as-needed -Wl,--sort-common -Wl,-O2 -Wl,-z,relro -Wl,-z,now -shared -Wl,-soname,libsight_module_filter_vision.so.21.1 -o ../../../lib/x86_64-linux-gnu/libsight_module_filter_vision.so.21.1.0 CMakeFiles/module_filter_vision.dir/Plugin.cpp.o CMakeFiles/module_filter_vision.dir/SColourImageMasking.cpp.o CMakeFiles/module_filter_vision.dir/SDepthImageMasking.cpp.o CMakeFiles/module_filter_vision.dir/SOpticalFlow.cpp.o CMakeFiles/module_filter_vision.dir/SPointCloudFromDepthMap.cpp.o CMakeFiles/module_filter_vision.dir/STransformDepthMap2mm.cpp.o CMakeFiles/module_filter_vision.dir/STransformDepthTL2mm.cpp.o CMakeFiles/module_filter_vision.dir/SUltrasoundImage.cpp.o CMakeFiles/module_filter_vision.dir/registerServices.cpp.o  -Wl,-rpath,/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/lib/x86_64-linux-gnu: /usr/lib/x86_64-linux-gnu/libopencv_highgui.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_video.so.4.6.0 ../../../lib/x86_64-linux-gnu/libsight_service.so.21.1.0 ../../../lib/x86_64-linux-gnu/libsight_geometry_data.so.21.1.0 ../../../lib/x86_64-linux-gnu/libsight_filter_vision.so.21.1.0 ../../../lib/x86_64-linux-gnu/libsight_io_opencv.so.21.1.0 /usr/lib/x86_64-linux-gnu/libopencv_videoio.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_imgcodecs.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_dnn.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_calib3d.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_features2d.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_imgproc.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_flann.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_core.so.4.6.0 ../../../lib/x86_64-linux-gnu/libsight_activity.so.21.1.0 /usr/lib/x86_64-linux-gnu/libopencv_ml.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_imgproc.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_core.so.4.6.0 ../../../lib/x86_64-linux-gnu/libsight_data.so.21.1.0 ../../../lib/x86_64-linux-gnu/libsight_core.so.21.1.0 /usr/lib/x86_64-linux-gnu/libboost_date_time.so.1.74.0 /usr/lib/x86_64-linux-gnu/libboost_log_setup.so.1.74.0 /usr/lib/x86_64-linux-gnu/libboost_log.so.1.74.0 /usr/lib/x86_64-linux-gnu/libboost_chrono.so.1.74.0 /usr/lib/x86_64-linux-gnu/libboost_filesystem.so.1.74.0 /usr/lib/x86_64-linux-gnu/libboost_regex.so.1.74.0 /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.74.0 /usr/lib/x86_64-linux-gnu/libboost_atomic.so.1.74.0 /usr/lib/x86_64-linux-gnu/libboost_iostreams.so.1.74.0 /usr/lib/x86_64-linux-gnu/libxml2.so /usr/lib/x86_64-linux-gnu/libcrypto.so -ldl /usr/lib/x86_64-linux-gnu/libopencv_calib3d.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_features2d.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_flann.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_imgproc.so.4.6.0 /usr/lib/x86_64-linux-gnu/libopencv_core.so.4.6.0
> In file included from /usr/include/ITK-5.3/itkLightObject.h:21,
>                   from /usr/include/ITK-5.3/itkObject.h:31,
>                   from /usr/include/ITK-5.3/itkLightProcessObject.h:21,
>                   from /usr/include/ITK-5.3/itkImageIOBase.h:24,
>                   from /<<PKGBUILDDIR>>/libs/io/itk/inr2itk/itkInrImageIOFactory.hpp:25,
>                   from /<<PKGBUILDDIR>>/libs/io/itk/ImageReader.cpp:25:
> /<<PKGBUILDDIR>>/libs/io/itk/helper/ProgressItkToFw.hxx:48:5: error: ‘LightObject’ in namespace ‘sight::io::itk’ does not name a type
>     48 |     itkNewMacro(Self);
>        |     ^~~~~~~~~~~
> /<<PKGBUILDDIR>>/libs/io/itk/helper/ProgressItkToFw.hxx: In static member function ‘static sight::io::itk::LocalCommand::Pointer sight::io::itk::LocalCommand::New()’:
> /<<PKGBUILDDIR>>/libs/io/itk/helper/ProgressItkToFw.hxx:48:5: error: ‘ObjectFactory’ is not a member of ‘sight::io::itk’; did you mean ‘itk::ObjectFactory’?
>     48 |     itkNewMacro(Self);
>        |     ^~~~~~~~~~~
> In file included from /usr/include/ITK-5.3/itkLightProcessObject.h:22:
> /usr/include/ITK-5.3/itkObjectFactory.h:55:7: note: ‘itk::ObjectFactory’ declared here
>     55 | class ObjectFactory : public ObjectFactoryBase
>        |       ^~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/libs/io/itk/helper/ProgressItkToFw.hxx:48:5: error: expected primary-expression before ‘>’ token
>     48 |     itkNewMacro(Self);
>        |     ^~~~~~~~~~~
> /<<PKGBUILDDIR>>/libs/io/itk/helper/ProgressItkToFw.hxx:48:5: error: ‘::Create’ has not been declared
>     48 |     itkNewMacro(Self);
>        |     ^~~~~~~~~~~
> [ 66%] Building CXX object libs/io/vtk/CMakeFiles/io_vtk.dir/ImageReader.cpp.o
>
> Cheers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20230823/10757209/attachment-0001.sig>