[Debian-med-packaging] Bug#964082: parsinsert fails it's tests when built with -O2 gcc-13

[Andreas Tille]

Hi Étienne,

Am Sun, Aug 27, 2023 at 11:26:32PM +0200 schrieb Étienne Mollier:
> 
> Rerunning these tests in a properly isolate chroot show me that
> the hardening is also contributing to the improper results.
> Hardening must be disabled and PIE must be enforced to ensure
> the program runs appropriately 
> 
> 	                         -O1  -O2   -O3
> 	-fPIE + no hardening      OK   OK    OK
> 	-fno-PIE + no hardening   OK  FAIL  FAIL
> 	-fPIE + hardening         OK  FAIL  FAIL
> 	-fno-PIE + hardening      OK  FAIL  FAIL

Thanks a lot for creating this matrix.
 
> I'm considering pushing an upload that goes in the direction of
> disabling hardening and enforcing PIE in the upcoming week,
> unless there are reasons to hold on, or someone is faster than
> me in uploading.

I will probably be not faster than you.  Please make sure you document
in d/rules that hardening breaks the tests.  This should avoid that
someone later might simply switch on hardening since we usually do this.
(may be same for salsa-ci.yaml when you switch of the CI test there.)

Thanks a lot for caring
   Andreas.

-- 
http://fam-tille.de