[Debian-med-packaging] Bug#1039903: libinsighttoolkit5-dev: Forcing C++14 makes plastimatch FTBFS

[Adrian Bunk]

Package: libinsighttoolkit5-dev
Version: 5.3.0-4
Severity: serious
Tags: ftbfs
Forwarded: https://github.com/InsightSoftwareConsortium/ITK/commit/513507e4c70172d5431563f89dc77c6bae1ad5b1
Control: affects -1 src:plastimatch

https://buildd.debian.org/status/fetch.php?pkg=plastimatch&arch=amd64&ver=1.9.4%2Bdfsg.1-1%2Bb1&stamp=1687722541&raw=0

...
cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/plastimatch/base && /usr/bin/c++ -DHDF_NO_NAMESPACE -DITK_FFTIMAGEFILTERINIT_FACTORY_REGISTER_MANAGER -DITK_IMAGEIO_FACTORY_REGISTER_MANAGER -DITK_MESHIO_FACTORY_REGISTER_MANAGER -DITK_TRANSFORMIO_FACTORY_REGISTER_MANAGER -DNO_STATIC_CAST -DOLD_HEADER_FILENAME -Dplmbase_EXPORTS -I/<<PKGBUILDDIR>>/src/plastimatch/base -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/plastimatch -I/<<PKGBUILDDIR>>/src/plastimatch/util/cuda -I/<<PKGBUILDDIR>>/src/plastimatch/util -I/<<PKGBUILDDIR>>/src/plastimatch/sys -I/<<PKGBUILDDIR>>/src/plastimatch/segment -I/<<PKGBUILDDIR>>/src/plastimatch/register/cuda -I/<<PKGBUILDDIR>>/src/plastimatch/register -I/<<PKGBUILDDIR>>/src/plastimatch/reconstruct/cuda -I/<<PKGBUILDDIR>>/src/plastimatch/reconstruct -I/<<PKGBUILDDIR>>/src/plastimatch/qt -I/<<PKGBUILDDIR>>/src/plastimatch/opencl -I/<<PKGBUILDDIR>>/src/plastimatch/cuda -I/<<PKGBUILDDIR>>/src/plastimatch/dose -I/<<PKGBUILDDIR>>/src/plastimatch/clp -I/<<PKGBUILDDIR>>/src/plastimatch/cli -I/<<PKGBUILDDIR>>/src/plastimatch -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/ITKFactoryRegistration -I/usr/lib/x86_64-linux-gnu/include -I/<<PKGBUILDDIR>>/libs/itk-5.1.0 -I/<<PKGBUILDDIR>>/libs/demons_itk_insight -I/<<PKGBUILDDIR>>/libs/demons_itk_insight/DiffeomorphicDemons -I/<<PKGBUILDDIR>>/libs/demons_itk_insight/FastSymmetricForces -I/<<PKGBUILDDIR>>/libs/demons_itk_insight/LOGDomainDemons -I/<<PKGBUILDDIR>>/libs/nSIFT -I/<<PKGBUILDDIR>>/libs/liblbfgs-1.9/include -I/<<PKGBUILDDIR>>/libs -I/<<PKGBUILDDIR>>/libs/ransac -I/<<PKGBUILDDIR>>/libs/ransac/Common -I/<<PKGBUILDDIR>>/libs/nkidecompress -I/<<PKGBUILDDIR>>/libs/devillard -isystem /usr/include/hdf5/serial -isystem /usr/include/gdcm-3.0 -isystem /usr/include/ITK-5.3 -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -fno-sized-deallocation -O3 -DNDEBUG -std=c++14 -fPIC -Wno-cpp -Wreturn-type -MD -MT src/plastimatch/base/CMakeFiles/plmbase.dir/aperture.cxx.o -MF CMakeFiles/plmbase.dir/aperture.cxx.o.d -o CMakeFiles/plmbase.dir/aperture.cxx.o -c /<<PKGBUILDDIR>>/src/plastimatch/base/aperture.cxx
...

In file included from /<<PKGBUILDDIR>>/src/plastimatch/base/dcmtk_config.h:16,
                 from /<<PKGBUILDDIR>>/src/plastimatch/base/metadata.h:12,
                 from /<<PKGBUILDDIR>>/src/plastimatch/base/plm_image.h:10,
                 from /<<PKGBUILDDIR>>/src/plastimatch/base/aperture.h:8,
                 from /<<PKGBUILDDIR>>/src/plastimatch/base/aperture.cxx:9:
/usr/include/dcmtk/config/osconfig.h:1153:2: error: invalid preprocessing directive #errorDCMTK
 1153 | #error\
      |  ^~~~~~
 1154 | DCMTK was configured to use C++17 features, but your compiler does not or was not configured to provide them.
      | ~~~~~
...



This is due to:
/usr/lib/x86_64-linux-gnu/cmake/ITK-5.3/ITKInitializeCXXStandard.cmake:  set(CMAKE_CXX_STANDARD 14) # Supported values are 14, 17, 20, and 23.