[Debian-med-packaging] Bug#1068341: bioawk: FTBFS randomly due to Makefile bug: cp: cannot create regular file 'ytab.c': File exists

[Santiago Vila]

Package: src:bioawk
Version: 1.0-4
Severity: important
Tags: ftbfs patch

Dear maintainer:

This package fails to build from source in a random fashion
due to what it seems to be a Makefile bug:

This is from my own autobuilder:

make[1]: Entering directory '/<<PKGBUILDDIR>>'
bison -y -d awkgram.y
bison -y -d awkgram.y
awkgram.y: warning: 43 shift/reduce conflicts [-Wconflicts-sr]
awkgram.y: warning: 85 reduce/reduce conflicts [-Wconflicts-rr]
awkgram.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
awkgram.y: warning: 43 shift/reduce conflicts [-Wconflicts-sr]
awkgram.y: warning: 85 reduce/reduce conflicts [-Wconflicts-rr]
awkgram.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
cp y.tab.c ytab.c
cp y.tab.c ytab.c
cp: cannot create regular file 'ytab.c': File exists
make[1]: *** [Makefile:49: ytab.h] Error 1
make[1]: *** Waiting for unfinished jobs....
cp y.tab.h ytab.h
gcc -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=for
mat-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c ytab.c
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j2 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2


This has also happened on the buildds several times:

https://buildd.debian.org/status/fetch.php?pkg=bioawk&arch=sparc64&ver=1.0-2&stamp=1614438070&raw=0
https://buildd.debian.org/status/fetch.php?pkg=bioawk&arch=riscv64&ver=1.0-2&stamp=1614441112&raw=0
https://buildd.debian.org/status/fetch.php?pkg=bioawk&arch=armhf&ver=1.0-3&stamp=1614527051&raw=0


I believe the error happens when the same target is being executed twice at the same time.

Given that the package is very small and it builds in a few seconds, I suggest
disabling parallel build as a simple and effective way to fix the problem.

Patch attached.

Thanks.
-------------- next part --------------
--- a/debian/rules
+++ b/debian/rules
@@ -5,7 +5,7 @@ DPKG_EXPORT_BUILDTOOLS = nonempty
 include /usr/share/dpkg/buildtools.mk
 
 %:
-	dh $@
+	dh $@ --no-parallel
 
 override_dh_auto_configure: